From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id 9A36C385E444 for ; Wed, 8 Jul 2020 10:06:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9A36C385E444 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-112-fH3hUD_JNyCewGD6IRMBWA-1; Wed, 08 Jul 2020 06:06:46 -0400 X-MC-Unique: fH3hUD_JNyCewGD6IRMBWA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AF2BC107ACCA for ; Wed, 8 Jul 2020 10:06:45 +0000 (UTC) Received: from blade.nx (ovpn-114-154.ams2.redhat.com [10.36.114.154]) by smtp.corp.redhat.com (Postfix) with ESMTP id 830DB5C1D3 for ; Wed, 8 Jul 2020 10:06:45 +0000 (UTC) Received: by blade.nx (Postfix, from userid 1000) id D4CBE816CCA9; Wed, 8 Jul 2020 11:06:44 +0100 (BST) Date: Wed, 8 Jul 2020 11:06:44 +0100 From: Gary Benson To: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] gdb: Improve formatting of 'show endian' messages Message-ID: <20200708100644.GB10907@blade.nx> References: <556fa65f8daa47ce8776fb12f0be0c06099f1a5c.1594198122.git.andrew.burgess@embecosm.com> MIME-Version: 1.0 In-Reply-To: <556fa65f8daa47ce8776fb12f0be0c06099f1a5c.1594198122.git.andrew.burgess@embecosm.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-8.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jul 2020 10:06:49 -0000 Andrew Burgess wrote: > This commit changes the output of 'show endian'. Here is a > session before this commit: > > (gdb) show endian > The target endianness is set automatically (currently little endian) > (gdb) set endian big > The target is assumed to be big endian > (gdb) show endian > The target is assumed to be big endian > (gdb) > > After this commit the session now looks like this: > > (gdb) show endian > The target endianness is set automatically (currently little endian). > (gdb) set endian big > The target is set to big endian. > (gdb) show endian > The target is set to big endian. > (gdb) > > The changes are: > > 1. Each line ends with '.', and > 2. After setting the endianness GDB is now a little more assertive; > 'target is set to' not 'target is assumed to be', the user did just > tell us after all! LGTM. Cheers, Gary -- Gary Benson - he / him / his Principal Software Engineer, Red Hat