From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailsec101.isp.belgacom.be (mailsec101.isp.belgacom.be [195.238.20.97]) by sourceware.org (Postfix) with ESMTPS id 8484138708C8 for ; Sat, 4 Jul 2020 14:24:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8484138708C8 IronPort-SDR: Hfg/qCaCMwuuFUxYwmJ4/SywKlVXKROLq3jumZ4OqlzLXtQTIvn/rfn8wW9cdEmX5KBYfaRFbb FY6dwTRFSgpFFaDEHjuidi+KkLsdhCVNRx1hgz40sG/6usoAETa5YhHVOtY4Dsl8gRjXesvkbK uCN015+cFRElqXBkl9Y1iGqQ+NxgTuPB3yDaqt+MDQXFB/hsbcMljU61N7XNBYzL9itX+VENtI ZKYracjaDTo0/dFhjYN/1ZmkZmvylQmXiCZc9xA8KhyAGgXnNeEZsNnO8vcRvdhzCdqDcBIQr4 HwI= IronPort-PHdr: =?us-ascii?q?9a23=3A+rx7AhLTF4Bna9Ol4NmcpTZWNBhigK39O0sv0r?= =?us-ascii?q?FitYgfLf/xwZ3uMQTl6Ol3ixeRBMOHsqwC07qd7PuoGTRZp8rY7TZaKN0Efi?= =?us-ascii?q?RGoP1epxYnDs+BBB+zB9/RRAt+Iv5/UkR49WqwK0lfFZW2TVTTpnqv8WxaQU?= =?us-ascii?q?2nZkJ6KevvB4Hdkdm82fys9J3PeQVIgye2ba9vIBmsogjdq8gbjZF+JqsyxR?= =?us-ascii?q?fEoHVFcPlSyW90OF6fhRnx6tqw8ZJ57yhcp/ct/NNcXKvneKg1UaZWByk8PW?= =?us-ascii?q?Av483ruxjDTQ+R6XYZT24bjBlGDRXb4R/jRpv+vTf0ueR72CmBIM35Vqs0Vi?= =?us-ascii?q?i476dqUxDnliEKPCMk/W7Ni8xwiKVboA+9pxF63oXZbp2ZOOZ4c6jAe94RWG?= =?us-ascii?q?hPUdtLVyFZAo2ycZYBAeQCM+hfoIbzqEADoQe9CAS2GO/i0CNEimPw0KYn0+?= =?us-ascii?q?ohCwbG3Ak4EtwUsHTUrdH1NKYKUeCt0qbD0DXMYOlM2Tf68YjIbxEhru+WXb?= =?us-ascii?q?JrbMHczlEvFwPEjlWUqIzlJyuV2foXv2mV9eVgT+Wvi3c6qwFwvDev3Nwsh5?= =?us-ascii?q?LShoIWylHE8zt2wJovKdKjVkF2eNipG4ZfuC+GLYV5WN8iQ312tyYgzL0LoZ?= =?us-ascii?q?22cScWxJg52xLSdfOKfoqI7B/tWuidPTh2in1qdbyxmRq8/1atx+/gWsS231?= =?us-ascii?q?hHrzRIn8TQun0PyxHd5ceKRuZ780y82jiPzxje5v9ZLU02j6bXNpAsz78qmp?= =?us-ascii?q?cQrEjPBCH7lUvwgaSLbEsr4PKo5P7iYrj+o5+cMJJ7hR/mP6Q1n8y/Hfw4Mg?= =?us-ascii?q?8TX2iH4ei81KPs/Un+QLhSi/05j7PVsJDdJcQeuKG1Gw5V0oA95BajFzqqzs?= =?us-ascii?q?kUkHsdIF5Ydh+KjpLlNlLTLPziA/qyjUygkDJxyPDHOr3hDI/NLn/GkLr5Zb?= =?us-ascii?q?Z9609cyA4yzdBH/5JbFKsNIfzpVU/rs9zYFwI5Mw2qzOb9E9VwzZgeWWGPA6?= =?us-ascii?q?+fLqzSrUWE6fkxLOWUfo8apC79K+Q55/7plXI5lkIScrKw0ZsPcn+4AuhpI0?= =?us-ascii?q?WHbnr3mdoBCmAKvhckTOP2llKDXyRcZ2ysUK4m4TE7Eo2mB5/ZRo+xmLyBwD?= =?us-ascii?q?u7HppOa2BeClCMEHPod4ScW/cUdi2eOMFgnSYeVbimUo8hyBCuuxHgy7p8Ne?= =?us-ascii?q?fU4S4YtJLl1Ndr++3fjwo9+iInR/iahm6BRSRsl38DRzIt9Lt4vFZ2x0iKy6?= =?us-ascii?q?U+hOZXRvJJ4PYcagc7MZ/E1+EyNNnoXRvcf9qTUx7yWtWnBTApVt933NYUZF?= =?us-ascii?q?9gGti4lTjY3DusDqNTnbHdV898yb7Vw3Wkf5U18H3BzqR011Q=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2DUBADCkABf/yFRiNlggRCEXFRfjTK?= =?us-ascii?q?GA54UCwEBAQEBAQEBAQgfDQECBAEBhEeCIyU4EwIDAQEBAwIFAQEGAQEBAQE?= =?us-ascii?q?BBQQBhg5Fgjcig04BIyNPgQKDJgGDAKxRhVGDWIFAgTiHe3OEC4FMP4ERiFi?= =?us-ascii?q?FByIEtGIoB4JfgQcEC4c1kHAPIIJznCqTPp0jgWqBeG2DPAlHGQ2cZ0IwNwI?= =?us-ascii?q?GCAEBAwlXASIBjFstghcBAQ?= X-IPAS-Result: =?us-ascii?q?A2DUBADCkABf/yFRiNlggRCEXFRfjTKGA54UCwEBAQEBA?= =?us-ascii?q?QEBAQgfDQECBAEBhEeCIyU4EwIDAQEBAwIFAQEGAQEBAQEBBQQBhg5Fgjcig?= =?us-ascii?q?04BIyNPgQKDJgGDAKxRhVGDWIFAgTiHe3OEC4FMP4ERiFiFByIEtGIoB4Jfg?= =?us-ascii?q?QcEC4c1kHAPIIJznCqTPp0jgWqBeG2DPAlHGQ2cZ0IwNwIGCAEBAwlXASIBj?= =?us-ascii?q?FstghcBAQ?= Received: from 33.81-136-217.adsl-dyn.isp.belgacom.be (HELO md.home) ([217.136.81.33]) by relay.skynet.be with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Jul 2020 16:24:35 +0200 From: Philippe Waroquiers To: gdb-patches@sourceware.org Subject: [RFAv2] Fine tune exec-file-mismatch help and documentation. Date: Sat, 4 Jul 2020 16:23:52 +0200 Message-Id: <20200704142352.3533-1-philippe.waroquiers@skynet.be> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Jul 2020 14:24:39 -0000 It was deemed better to explicitly mention in help and doc that build IDs are used for comparison, and that symbols are loaded when asking to load the exec-file. This is V2, fixing 2 typos and replacing 'If the user asks to load' by 'If the user confirms loading', as suggested by Pedro. gdb/ChangeLog 2020-07-04 Philippe Waroquiers * exec.c (_initialize_exec): Update exec-file-mismatch help. gdb/doc/ChangeLog 2020-07-04 Philippe Waroquiers * gdb.texinfo (Attach): Update exec-file-mismatch doc. --- gdb/doc/gdb.texinfo | 2 ++ gdb/exec.c | 8 ++++++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index fbe9f850af..eac3a3a87e 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -3016,6 +3016,8 @@ by @value{GDBN} and the executable file used to start the process. If @samp{ask}, the default, display a warning and ask the user whether to load the process executable file; if @samp{warn}, just display a warning; if @samp{off}, don't attempt to detect a mismatch. +If the user confirms loading the process executable file, then its symbols +will be loaded as well. @cindex show exec-file-mismatch @item show exec-file-mismatch diff --git a/gdb/exec.c b/gdb/exec.c index de473fbcb2..2ff5846c0e 100644 --- a/gdb/exec.c +++ b/gdb/exec.c @@ -305,7 +305,7 @@ validate_exec_file (int from_tty) exec_file_target = TARGET_SYSROOT_PREFIX + exec_file_target; warning - (_("Mismatch between current exec-file %ps\n" + (_("Build ID mismatch between current exec-file %ps\n" "and automatically determined exec-file %ps\n" "exec-file-mismatch handling is currently \"%s\""), styled_string (file_name_style.style (), current_exec_file), @@ -1269,7 +1269,11 @@ loaded by GDB and the exec-file automatically determined when attaching\n\ to a process:\n\n\ ask - warn the user and ask whether to load the determined exec-file.\n\ warn - warn the user, but do not change the exec-file.\n\ - off - do not check for mismatch."), + off - do not check for mismatch.\n\ +\n\ +GDB detects a mismatch by comparing the build IDs of the files.\n\ +If the user confirms loading the determined exec-file, then its symbols\n\ +will be loaded as well."), set_exec_file_mismatch_command, show_exec_file_mismatch_command, &setlist, &showlist); -- 2.20.1