From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id 988BA3861916 for ; Fri, 3 Jul 2020 13:09:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 988BA3861916 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-202-4NcL74dcPZSgPmh1ZTsiwA-1; Fri, 03 Jul 2020 09:09:47 -0400 X-MC-Unique: 4NcL74dcPZSgPmh1ZTsiwA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6A7041009600; Fri, 3 Jul 2020 13:09:46 +0000 (UTC) Received: from blade.nx (ovpn-113-167.ams2.redhat.com [10.36.113.167]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3DC1817D8F; Fri, 3 Jul 2020 13:09:46 +0000 (UTC) Received: by blade.nx (Postfix, from userid 1000) id 7821D816CCA9; Fri, 3 Jul 2020 14:09:45 +0100 (BST) Date: Fri, 3 Jul 2020 14:09:45 +0100 From: Gary Benson To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Make out of range type conversions explicit Message-ID: <20200703130945.GA16144@blade.nx> References: <1593525480-5685-1-git-send-email-gbenson@redhat.com> <20200703093018.GB8482@blade.nx> <70597daf-9f55-fff8-6503-7602c204028a@palves.net> MIME-Version: 1.0 In-Reply-To: <70597daf-9f55-fff8-6503-7602c204028a@palves.net> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-14.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jul 2020 13:09:50 -0000 Pedro Alves wrote: > On 7/3/20 10:30 AM, Gary Benson wrote: > > Pedro Alves wrote: > > > diff --git a/gdb/testsuite/gdb.base/structs2.c b/gdb/testsuite/gdb.base/structs2.c > > > index 7c8be035221..aac7bce8c15 100644 > > > --- a/gdb/testsuite/gdb.base/structs2.c > > > +++ b/gdb/testsuite/gdb.base/structs2.c > > > @@ -13,7 +13,7 @@ main () > > > > > > bkpt = 0; > > > param_reg (120, 130, 32000, 33000); > > > - param_reg (130, 120, 33000, 32000); > > > + param_reg (-120, 130, -32000, 33000); > > > > > > return 0; > > > } > > > > On first glance I thought this was a copy-paste error. I don't > > think it is, but, just in case, can you confirm the change above > > is what you intended? > > What do you mean by "this"? If you mean, the proposed change > instead of: > > param_reg (120, 130, 32000, 33000); > - param_reg (130, 120, 33000, 32000); > + param_reg (-130, 120, -33000, 32000); > > It's just that -130 and -33000 overflows, so I swapped the > numbers back. Cool, thank you. Cheers, Gary -- Gary Benson - he / him / his Principal Software Engineer, Red Hat