Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Gary Benson <gbenson@redhat.com>
To: Tom de Vries <tdevries@suse.de>
Cc: Pedro Alves <pedro@palves.net>, gdb-patches@sourceware.org
Subject: Re: [committed][gdb/testsuite] Update psym-external-decl.exp for gcc-10/clang
Date: Fri, 3 Jul 2020 10:21:07 +0100	[thread overview]
Message-ID: <20200703092107.GA8482@blade.nx> (raw)
In-Reply-To: <db38817d-b572-dce7-da4e-dcaf45348002@suse.de>

Tom de Vries wrote:
> On 6/29/20 2:32 PM, Pedro Alves wrote:
> > On 6/28/20 11:50 AM, Tom de Vries wrote:
> > > I think the following is a good way of dealing with this.
> > >
> > > We introduce a proc in gdb.exp called debug_info_for_decl or
> > > some such, that returns false by default for clang.
> > 
> > I think it would be useful to include an intro description to
> > 
> >  gdb.base/psym-external-decl.exp
> > 
> > since it currently doesn't describe what it is testing.  Looking
> > at the commit log of the patch that introduced it helps, but
> > one shouldn't have to do that.
> > 
> > So the difference between gcc and clang AFAIU is that gcc emits
> > debug info for the extern variable declaration (and with newer GCCs,
> > only if there's a reference to the variable in the CU, otherwise
> > not even so), while seemingly clang would only emit debug info for
> > the variable's definition, which isn't compiled with -g, so we
> > end up with no debug info for the variable.
> > 
> > I would suggest filing a bug with clang, to confirm whether
> > this is intentional, or whether they see it as a bug.  I would
> > think it is a bug, but I'm not sure.  If indeed a bug, we would
> > XFAIL the test.
> 
> I've filed https://bugs.llvm.org/show_bug.cgi?id=46514 .
> 
> Thanks,
> - Tom

Thank for filing it Tom.

Cheers,
Gary

-- 
Gary Benson - he / him / his
Principal Software Engineer, Red Hat



  reply	other threads:[~2020-07-03  9:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-02  7:51 Tom de Vries
2020-06-17 12:24 ` Gary Benson
2020-06-17 13:56   ` Tom de Vries
2020-06-18 16:10     ` Gary Benson
2020-06-18 16:27       ` Tom de Vries
2020-06-19 14:00         ` Gary Benson
2020-06-19 14:06           ` Tom de Vries
2020-06-26  9:37             ` Gary Benson
2020-06-28 10:50               ` Tom de Vries
2020-06-29 12:32                 ` Pedro Alves
2020-06-30  8:14                   ` Tom de Vries
2020-07-03  9:21                     ` Gary Benson [this message]
2020-07-03 11:20                       ` Pedro Alves
2020-07-03 11:24                         ` Tom de Vries
2020-07-03 11:32                           ` Pedro Alves
2020-07-03 12:50                             ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200703092107.GA8482@blade.nx \
    --to=gbenson@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@palves.net \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox