From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by sourceware.org (Postfix) with ESMTP id 6229F3858D34 for ; Thu, 2 Jul 2020 10:02:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6229F3858D34 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-88-InPs3sWxNjWKiAiHgKPgwA-1; Thu, 02 Jul 2020 06:02:02 -0400 X-MC-Unique: InPs3sWxNjWKiAiHgKPgwA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 69089108BD0B; Thu, 2 Jul 2020 10:02:01 +0000 (UTC) Received: from blade.nx (ovpn-112-246.ams2.redhat.com [10.36.112.246]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2AD3060CD1; Thu, 2 Jul 2020 10:02:01 +0000 (UTC) Received: by blade.nx (Postfix, from userid 1000) id 72A03816CCA9; Thu, 2 Jul 2020 11:02:00 +0100 (BST) Date: Thu, 2 Jul 2020 11:02:00 +0100 From: Gary Benson To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] W/ Clang, compile C/C++ testcases with -Wno-unknown-warning-option Message-ID: <20200702100200.GB7741@blade.nx> References: <1590757423-18004-1-git-send-email-gbenson@redhat.com> <87mu5qaa2b.fsf@tromey.com> <68fd1b3e-10ae-8f1d-b96d-f35ce7ae3037@redhat.com> <20200616124212.GB30305@blade.nx> <5b75188a-0c0e-528a-1bbd-213f5fa52bd4@redhat.com> <20200617172913.GA5386@blade.nx> <4a87b8c6-a71c-cb54-8e23-7388c7128c2e@redhat.com> <20200618161829.GB1032@blade.nx> <4cba48fd-47d8-1a1c-59a0-c1b7ed85aba0@redhat.com> MIME-Version: 1.0 In-Reply-To: <4cba48fd-47d8-1a1c-59a0-c1b7ed85aba0@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jul 2020 10:02:05 -0000 Pedro Alves wrote: > On 6/18/20 5:18 PM, Gary Benson via Gdb-patches wrote: > > Pedro Alves wrote: > > > gdb/testsuite/ChangeLog: > > > * lib/gdb.exp (gdb_compile): Update intro comment. If C/C++ > > > with Clang, add "-Wno-unknown-warning-option" to the options. > > > > Oh, thanks, that looks great. Could you commit it please? > > I've pushed this now, with just a tweak to also list "go". Thanks Pedro, I was lost in all the special cases in there! Cheers, Gary -- Gary Benson - he / him / his Principal Software Engineer, Red Hat