From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailsec117.isp.belgacom.be (mailsec117.isp.belgacom.be [195.238.20.113]) by sourceware.org (Postfix) with ESMTPS id 022463851C0A for ; Sat, 27 Jun 2020 20:12:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 022463851C0A IronPort-SDR: 5qwGigOJDHHiGrgCQUlyCfqIAESV4+CBYFPP5s1/aVeot2pjIQr0YGU7F6S8g9IzOVZjgjBJtU KvLDkPtHljaHFCdPAi4GajjYRa0iq69Z79kea2uVAp8zSyEy29fBPWjjxFL9yXwkuftG93LtG3 0Niv4AMcmfPXP/C7Xbt/kO6F4APR5YKRdpN1r80CpzSt/w5I8TPF69pdhLa6uzn9aCTv752mws Jjue3GDncCww0YLs8Gjrt/wdEF4fPt4k00tAkm6uCVzYKUgWnCNXhm5d35gOQZbhwdefKh3qSk tEE= IronPort-PHdr: =?us-ascii?q?9a23=3AZLqEWR93R+m/Jv9uRHKM819IXTAuvvDOBiVQ1K?= =?us-ascii?q?B21+kcTK2v8tzYMVDF4r011RmVBNidsqMfwLOK7ujJYi8p2d65qncMcZhBBV?= =?us-ascii?q?cuqP49uEgeOvODElDxN/XwbiY3T4xoXV5h+GynYwAOQJ6tL1LdrWev4jEMBx?= =?us-ascii?q?7xKRR6JvjvGo7Vks+7y/2+94fcbglVhDexe65+IRG4oAneq8UbjotvIbstxx?= =?us-ascii?q?XUpXdFZ/5Yzn5yK1KJmBb86Maw/Jp9/ClVpvks6c1OX7jkcqohVbBXAygoPG?= =?us-ascii?q?4z5M3wqBnMVhCP6WcGUmUXiRVHHQ7I5wznU5jrsyv6su192DSGPcDzULs5Vy?= =?us-ascii?q?iu47ttRRT1jioMKjw3/3zNisFojKxVvg+vqRJ8zYDTb46bO+Fzcr/ecN4AWW?= =?us-ascii?q?ZMRNpdWzBHD4ihb4UPFe0BPeNAoofnp1sOrB++BQi0BOP31DBDm3/50rcg0+?= =?us-ascii?q?QmCAHGwQ0gEMwUsHTPsd74M78SUeC0zKnMzDXDd+tW1inn5InGaB8hu/aMXa?= =?us-ascii?q?ttccrQ10YvDRjFg06LqYzmPzKV0PoCs3SB4+V7S+2ikmgqoBx+rTaz3MkjkJ?= =?us-ascii?q?XJhp4LxVDe8yV02IU4KNKkREJlfdKpDpRduiOaOYZ4TM0uX25mtik1x7MIp5?= =?us-ascii?q?K1cjYHxZY7yxPdZPKKcpaF7w//WOuTPTp2i31odK+5ih2v8kag0vXxWtep3F?= =?us-ascii?q?tItCZJj9fBu3EX2xHQ98SLUPVw80mn1D2SzQ7c8PtELloxlafDLp4hxaM/mY?= =?us-ascii?q?QLvETYGy/2hF32jKiLdkU44uSo6/roYrHhppKEMo97lxvyMqQpmsy6H+s0Kg?= =?us-ascii?q?kOX26F9uSgzLDv41D1TbdQgvErnKTUsYrWKMcGqqKjDQJY3J4v6xOlADen1N?= =?us-ascii?q?QYk2MHLFVAeB+fl4jpO1DOIPT5Dfenm1Sjji1nxv7cMb37BZXNN2XDkLb/cr?= =?us-ascii?q?Zn8E5R0xEzzdNf5pJSFL4BPOj/VVTvu9DAFB82LxS0w/r7CNV6zo4eVn+ADb?= =?us-ascii?q?SAPKPKq1CI+v4gI+mSa48Oozv9MP8l5+P0jXAlh1Acc7Om3YEJZ3yiGfRmOU?= =?us-ascii?q?qZa2L2gtgdCWcKohY+TOvyhV2aUT5TZnKyX6Mk5jEjFo2qF4nCSZq3gLyGxS?= =?us-ascii?q?e7A5xWaX5cClCXCnrobIaEWvcKaC2MPs9tiCcLWqbyA7MmgB6ivkriwqZsLu?= =?us-ascii?q?fP0jYfqIjo2cd8/eCVkgs9phJuCMHI62GMS2Bshm5AeDYs27lioEFn0R/Xya?= =?us-ascii?q?h5h/1ADdEV+PpTVR4nNJPG1MRhCMH0Vx6HdNrfGwXuecmvHTxkFoF5+NQJeU?= =?us-ascii?q?soQ9g=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2DUBAA3p/de/yFRiNlggRCEXFRfjTG?= =?us-ascii?q?GA54TCwEBAQEBAQEBAQgfDQECBAEBhEeCLSU4EwIDAQEBAwIFAQEGAQEBAQE?= =?us-ascii?q?BBQQBhg5Fgjcig04BIyNPgQKDJgGDAK8ShVGDYoFAgTiHeHOECoFMP4ERiFi?= =?us-ascii?q?FByIEtFAoB4JfgQcEC4cxkGYPIIJznCABkzKdGYFqgXhtgzwJRxkNnGZCMDc?= =?us-ascii?q?CBggBAQMJVwEiAY03LYIXAQE?= X-IPAS-Result: =?us-ascii?q?A2DUBAA3p/de/yFRiNlggRCEXFRfjTGGA54TCwEBAQEBA?= =?us-ascii?q?QEBAQgfDQECBAEBhEeCLSU4EwIDAQEBAwIFAQEGAQEBAQEBBQQBhg5Fgjcig?= =?us-ascii?q?04BIyNPgQKDJgGDAK8ShVGDYoFAgTiHeHOECoFMP4ERiFiFByIEtFAoB4Jfg?= =?us-ascii?q?QcEC4cxkGYPIIJznCABkzKdGYFqgXhtgzwJRxkNnGZCMDcCBggBAQMJVwEiA?= =?us-ascii?q?Y03LYIXAQE?= Received: from 33.81-136-217.adsl-dyn.isp.belgacom.be (HELO md.home) ([217.136.81.33]) by relay.skynet.be with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Jun 2020 22:12:56 +0200 From: Philippe Waroquiers To: gdb-patches@sourceware.org Subject: [RFA] Fine tune exec-file-mismatch help and documentation. Date: Sat, 27 Jun 2020 22:12:43 +0200 Message-Id: <20200627201243.21594-1-philippe.waroquiers@skynet.be> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Jun 2020 20:12:59 -0000 It was deemed better to explicitly mention in help and doc that build IDs are used for comparison, and that symbols are loaded when asking to load the exec-file. gdb/ChangeLog 2020-06-27 Philippe Waroquiers * exec.c (_initialize_exec): Update exec-file-mismatch help. gdb/doc/ChangeLog 2020-06-27 Philippe Waroquiers * gdb.texinfo (Attach): Updte exec-file-mismatch doc. --- gdb/doc/gdb.texinfo | 2 ++ gdb/exec.c | 8 ++++++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index fbe9f850af..142684b694 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -3016,6 +3016,8 @@ by @value{GDBN} and the executable file used to start the process. If @samp{ask}, the default, display a warning and ask the user whether to load the process executable file; if @samp{warn}, just display a warning; if @samp{off}, don't attempt to detect a mismatch. +If the user asks to load the process ececutable file, then its symbols +will be loaded as well. @cindex show exec-file-mismatch @item show exec-file-mismatch diff --git a/gdb/exec.c b/gdb/exec.c index de473fbcb2..84e75e0798 100644 --- a/gdb/exec.c +++ b/gdb/exec.c @@ -305,7 +305,7 @@ validate_exec_file (int from_tty) exec_file_target = TARGET_SYSROOT_PREFIX + exec_file_target; warning - (_("Mismatch between current exec-file %ps\n" + (_("Build ID mismatch between current exec-file %ps\n" "and automatically determined exec-file %ps\n" "exec-file-mismatch handling is currently \"%s\""), styled_string (file_name_style.style (), current_exec_file), @@ -1269,7 +1269,11 @@ loaded by GDB and the exec-file automatically determined when attaching\n\ to a process:\n\n\ ask - warn the user and ask whether to load the determined exec-file.\n\ warn - warn the user, but do not change the exec-file.\n\ - off - do not check for mismatch."), + off - do not check for mismatch.\n\ +\n\ +GDB detects a mismatch by comparing the build IDs of the files.\n\ +If the user asks to load the determined exec-file, then its symbols\n\ +will be loaded as well."), set_exec_file_mismatch_command, show_exec_file_mismatch_command, &setlist, &showlist); -- 2.20.1