Re: [PATCH 1/5] gdb: Remove deprecated_set_gdbarch_data

Tom Tromey
2020-06-18T21:11:23Z

>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:

Andrew> * gdbarch.c: Regenerate.
Andrew> * gdbarch.h: Regenerate.
Andrew> * gdbarch.sh (deprecated_set_gdbarch_data): Delete.
Andrew> (gdbarch_data): Use internal_error for the case where
Andrew> deprecated_set_gdbarch_data was originally needed.
Andrew> * ia64-libunwind-tdep.c (libunwind_descr_init): Update parameters,
Andrew> and use passed in obstack.
Andrew> (libunwind_frame_set_descr): Should no longer get back NULL from
Andrew> gdbarch_data.
Andrew> (_initialize_libunwind_frame): Register as a pre-init gdbarch data
Andrew> type.
Andrew> * user-regs.c (user_regs_init): Update parameters, and use passed
Andrew> in obstack.
Andrew> (user_reg_add): Should no longer get back NULL from gdbarch_data.
Andrew> (_initialize_user_regs): Register as a pre-init gdbarch data type.

Seems fine to me.

Tom