From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id 8563538708A4 for ; Thu, 18 Jun 2020 16:10:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8563538708A4 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-146-ohSkonA6MGCIcURj1c9hjg-1; Thu, 18 Jun 2020 12:10:46 -0400 X-MC-Unique: ohSkonA6MGCIcURj1c9hjg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 951121005512; Thu, 18 Jun 2020 16:10:45 +0000 (UTC) Received: from blade.nx (ovpn-115-39.ams2.redhat.com [10.36.115.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5B1675BAC1; Thu, 18 Jun 2020 16:10:45 +0000 (UTC) Received: by blade.nx (Postfix, from userid 1000) id 9BD2A816CCA9; Thu, 18 Jun 2020 17:10:44 +0100 (BST) Date: Thu, 18 Jun 2020 17:10:44 +0100 From: Gary Benson To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [committed][gdb/testsuite] Update psym-external-decl.exp for gcc-10/clang Message-ID: <20200618161044.GA1032@blade.nx> References: <20200502075127.GA21196@delia> <20200617122432.GA28940@blade.nx> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-15.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jun 2020 16:10:51 -0000 Tom de Vries wrote: > On 6/17/20 2:24 PM, Gary Benson wrote: > > Tom de Vries wrote: > > > Fix the test-case [with gcc-10] by adding a use of aaa in psym-external-decl.c. > > ... > > > That still doesn't work for clang, so skip test in that case. > > .. > > > diff --git a/gdb/testsuite/gdb.base/psym-external-decl.exp b/gdb/testsuite/gdb.base/psym-external-decl.exp > > > index bbcc2745755..d0388d5655e 100644 > > > --- a/gdb/testsuite/gdb.base/psym-external-decl.exp > > > +++ b/gdb/testsuite/gdb.base/psym-external-decl.exp > > > @@ -15,6 +15,11 @@ > > > > > > standard_testfile .c psym-external-decl-2.c > > > > > > +get_compiler_info > > > +if { [test_compiler_info "clang-*"] } { > > > + return -1 > > > +} > > > + > > > set srcfiles [list $srcfile $srcfile2] > > > > > > if { [build_executable_from_specs \ > > > > Tom, I'd like this testcase to not fail silently. Is the > > functionality under test something that isn't ever expected to > > work with clang, or is this a test that should pass with clang > > (but it currently doesn't, for whatever reason)? > > I'm not sure. The test can pass with clang, provided it generates the > required debug info. It currently doesn't. Why that is the case, I > have no idea. I think that means the test should work but it doesn't. Would you object if I push a patch removing the test-skipping logic? It will mean an extra FAIL when tested using clang Thanks, Gary -- Gary Benson - he / him / his Principal Software Engineer, Red Hat