Re: [PATCH 4/5] gdb/python: New method to access list of register groups

Tom Tromey
2020-06-18T21:27:35Z

>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:

Andrew> Add a new method gdb.Architecture.register_groups which returns a new
Andrew> object of type gdb.RegisterGroupsIterator. This new iterator then
Andrew> returns objects of type gdb.RegisterGroup.

Andrew> Each gdb.RegisterGroup object just wraps a single reggroup pointer,
Andrew> and (currently) has just one read-only property 'name' that is a
Andrew> string, the name of the register group.

Andrew> As with the previous commit (adding gdb.RegisterDescriptor) I made
Andrew> gdb.RegisterGroup an object rather than just a string in case we want
Andrew> to add additional properties in the future.

FWIW this looks good to me.

thanks,
Tom