Re: [committed][gdb/testsuite] Update psym-external-decl.exp for gcc-10/clang

Tom de Vries
2020-06-18T16:28:01Z

On 6/18/20 6:10 PM, Gary Benson wrote:
> Tom de Vries wrote:
>> On 6/17/20 2:24 PM, Gary Benson wrote:
>>> Tom de Vries wrote:
>>>> Fix the test-case [with gcc-10] by adding a use of aaa in psym-external-decl.c.
>>> ...
>>>> That still doesn't work for clang, so skip test in that case.
>>> ..
>>>> diff --git a/gdb/testsuite/gdb.base/psym-external-decl.exp b/gdb/testsuite/gdb.base/psym-external-decl.exp
>>>> index bbcc2745755..d0388d5655e 100644
>>>> --- a/gdb/testsuite/gdb.base/psym-external-decl.exp
>>>> +++ b/gdb/testsuite/gdb.base/psym-external-decl.exp
>>>> @@ -15,6 +15,11 @@
>>>>
>>>> standard_testfile .c psym-external-decl-2.c
>>>>
>>>> +get_compiler_info
>>>> +if { [test_compiler_info "clang-*"] } {
>>>> + return -1
>>>> +}
>>>> +
>>>> set srcfiles [list $srcfile $srcfile2]
>>>>
>>>> if { [build_executable_from_specs \
>>>
>>> Tom, I'd like this testcase to not fail silently. Is the
>>> functionality under test something that isn't ever expected to
>>> work with clang, or is this a test that should pass with clang
>>> (but it currently doesn't, for whatever reason)?
>>
>> I'm not sure. The test can pass with clang, provided it generates the
>> required debug info. It currently doesn't. Why that is the case, I
>> have no idea.
>
> I think that means the test should work but it doesn't. Would you
> object if I push a patch removing the test-skipping logic? It will
> mean an extra FAIL when tested using clang
>

Hi Gary,

I don't think having a fail for a compiler bug/missing-feature is a good
idea.

If this is due to a bug/missing-feature in clang, then we need to:
- xfail the test,
- file the PR in clang, and
- reference the PR at the xfail.

If this is a wontfix for clang, then we can mark it unsupported.

Thanks,
- Tom