From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id 9FE07388F043 for ; Wed, 17 Jun 2020 12:24:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9FE07388F043 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-54-ArVmIK-ZNR67viFVXEvHNg-1; Wed, 17 Jun 2020 08:24:35 -0400 X-MC-Unique: ArVmIK-ZNR67viFVXEvHNg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E3BDFE936; Wed, 17 Jun 2020 12:24:33 +0000 (UTC) Received: from blade.nx (ovpn-114-126.ams2.redhat.com [10.36.114.126]) by smtp.corp.redhat.com (Postfix) with ESMTP id B05C3104C41A; Wed, 17 Jun 2020 12:24:33 +0000 (UTC) Received: by blade.nx (Postfix, from userid 1000) id D9C3E816CCA9; Wed, 17 Jun 2020 13:24:32 +0100 (BST) Date: Wed, 17 Jun 2020 13:24:32 +0100 From: Gary Benson To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [committed][gdb/testsuite] Update psym-external-decl.exp for gcc-10/clang Message-ID: <20200617122432.GA28940@blade.nx> References: <20200502075127.GA21196@delia> MIME-Version: 1.0 In-Reply-To: <20200502075127.GA21196@delia> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-15.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2020 12:24:39 -0000 Tom de Vries wrote: > Fix the test-case [with gcc-10] by adding a use of aaa in psym-external-decl.c. ... > That still doesn't work for clang, so skip test in that case. .. > diff --git a/gdb/testsuite/gdb.base/psym-external-decl.exp b/gdb/testsuite/gdb.base/psym-external-decl.exp > index bbcc2745755..d0388d5655e 100644 > --- a/gdb/testsuite/gdb.base/psym-external-decl.exp > +++ b/gdb/testsuite/gdb.base/psym-external-decl.exp > @@ -15,6 +15,11 @@ > > standard_testfile .c psym-external-decl-2.c > > +get_compiler_info > +if { [test_compiler_info "clang-*"] } { > + return -1 > +} > + > set srcfiles [list $srcfile $srcfile2] > > if { [build_executable_from_specs \ Tom, I'd like this testcase to not fail silently. Is the functionality under test something that isn't ever expected to work with clang, or is this a test that should pass with clang (but it currently doesn't, for whatever reason)? If the former (it isn't ever expected to work), can this test please call to unsupported/untested, so there's at least something in the .sum file? If it's the latter (the test should pass, but it doesn't), can the skip-the-test block please be removed, so the test can fail? Whichever it is, I'm happy to make the commit, or you can if you like, I'm easy. Thanks, Gary