Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@adacore.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 0/4] Unify string-reading APIs
Date: Fri, 12 Jun 2020 15:53:52 -0600	[thread overview]
Message-ID: <20200612215356.22145-1-tromey@adacore.com> (raw)

An old comment notes that gdb has several different ways to read a
string from the target.  This series tries to simplify this situation.

read_memory_string is removed entirely.  Perhaps this is the better
name, in the end; but I didn't want to move read_string into
corelow.c.  Maybe we need a new file for the memory-reading functions
that are there?  (Also I wonder if any of the remaining ones are
redundant.)

target_read_string is first rewritten in terms of read_string.  A
subsequent patch changes its API to be simpler.

Perhaps further simplification could be done as well.  I'm open to
suggestions.

Regression tested on x86-64 Fedora 30.  I also built it using a mingw
cross, to make sure windows-nat.c still builds.

Tom




             reply	other threads:[~2020-06-12 21:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-12 21:53 Tom Tromey [this message]
2020-06-12 21:53 ` [PATCH 1/4] Remove read_memory_string Tom Tromey
2020-06-13 14:19   ` Simon Marchi
2020-06-15 12:37   ` Pedro Alves
2020-06-12 21:53 ` [PATCH 2/4] Rewrite target_read_string Tom Tromey
2020-06-12 21:53 ` [PATCH 3/4] Remove a use of target_read_string Tom Tromey
2020-06-13  3:04   ` Sergio Durigan Junior
2020-06-15 12:13     ` Tom Tromey
2020-06-12 21:53 ` [PATCH 4/4] Change target_read_string API Tom Tromey
2020-06-13 14:40   ` Simon Marchi
2020-06-13 14:40 ` [PATCH 0/4] Unify string-reading APIs Simon Marchi
2020-06-15 12:27   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200612215356.22145-1-tromey@adacore.com \
    --to=tromey@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox