From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by sourceware.org (Postfix) with ESMTPS id 4A3CC388B034 for ; Tue, 9 Jun 2020 22:58:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4A3CC388B034 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wr1-x42f.google.com with SMTP id l11so153601wru.0 for ; Tue, 09 Jun 2020 15:58:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Ku1gt5B/qw38ZwCIKe8E6dTcmBEgc/E4wrztv9Uq9+4=; b=YnOq8IDJAhc/HNraKUYHyLvxlzJJOOMsMYNi1rM6fMoAXttIDPOtAA2oqje8rgqVC6 ksQOAQZQgkXz5UBhoTHho7Ogp6mfYTjEsNbBFCn+zVzHJw9mx/7t29ukZSe/PcgM7aLu PsEPDPXfmnLgGK3yVAZWv3Zl5FquQPCo4SivV0KzBUvtsHR4TbiVvhZe+qpBhQaDpOyd cNx9tU6+KGmNvecfDifvHijho44dOPUa1wurJepRUqhTm8Nf0fRx7e7eDJCWgZFnjtZI zonTu4IhwWE3svyO7ddvS8wFiGlKL08szwZcyL3Cq0y/+7876ytPoNS3Sqd6A15byKfR K7Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Ku1gt5B/qw38ZwCIKe8E6dTcmBEgc/E4wrztv9Uq9+4=; b=kjCTpEMJZzVVh5gRqdgUSPK+rhbGfcKeLZD6lvV3shIPx0V7Besccr9MGCAGQhi9En MRa64siN2TDF8SVS5HzVaDpcOeQjBRIkIJ8GoMIfN+NwbAsGmicRIUL1vXS2d9dTcN6V NXXWwEPCm20kUey8OUxS0WcY82oCxdWe1NmxMNjeimXduwXd6yS2x7dtavmbdDx5cYjC NM1akHIWrDBG8ghR47bpTM/NRfxrlR1rgfVW87nvDKdqZHGK49+ImjsxspIspojpALto lGimaqe7PIjenmGEetpb+ejTinL+AhBW4cLr2qViz5rsQ7BQfikTV4gdKmQuuQcgrRmK YLeA== X-Gm-Message-State: AOAM532r5HfSV82Akwrn0zaPCY/U5lKW83GTPkoDjSop5XTZJRXPNx5A lvHEnEb9ZKtvJRZFZn93quev2w== X-Google-Smtp-Source: ABdhPJxA5kPukJ9vwDSIfKK8FjYcQ6bvnmV4DWf75HxxBLBtlyM09/ILgvF5w+Yp1ZcyBOMAt1ekBQ== X-Received: by 2002:adf:e68a:: with SMTP id r10mr163276wrm.384.1591743518442; Tue, 09 Jun 2020 15:58:38 -0700 (PDT) Received: from localhost (host86-128-12-16.range86-128.btcentralplus.com. [86.128.12.16]) by smtp.gmail.com with ESMTPSA id b14sm887113wmb.20.2020.06.09.15.58.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2020 15:58:37 -0700 (PDT) Date: Tue, 9 Jun 2020 23:58:36 +0100 From: Andrew Burgess To: Tom Tromey Cc: Nelson Chu , gdb-patches@sourceware.org Subject: Re: [RFC] gdb/riscv: Improved register alias name creation Message-ID: <20200609225836.GH2737@embecosm.com> References: <1584007257-14466-1-git-send-email-nelson.chu@sifive.com> <87r1upefg8.fsf@tromey.com> <20200609173040.GE2737@embecosm.com> <87pna855a8.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87pna855a8.fsf@tromey.com> X-Operating-System: Linux/5.6.15-200.fc31.x86_64 (x86_64) X-Uptime: 23:48:05 up 1 day, 12:55, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, URIBL_CSS, URIBL_CSS_A autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jun 2020 22:58:40 -0000 * Tom Tromey [2020-06-09 14:54:23 -0600]: > >>>>> "Andrew" == Andrew Burgess writes: > > Andrew> The patch below has had only minimal testing so far, but I'm sharing > Andrew> it here so it can be discussed while I also get it tested. > > Andrew> This changes how the 'csr%d' aliases are created, and adds the > Andrew> dscratch to dscratch0 alias. > > I backed out the reversion here; then I did a new merge; then I applied > this patch and re-ran our internal test suite. > > It still fails -- though it does change the failures I see. Now it > complains about a different register: > > (gdb) call debug.trace (me, "You") > Could not fetch register "mucounteren"; remote failure reply 'E14' So I forgot to say, the reason I'm so confused by this is that getting the 'remote failure reply ...' message indicates that GDB does know about the register, is correctly asking for it, but the remote is not providing the register. I rolled GDB back to commit d8af906814bd69dad694e475288401b1dee6ac3a, which is just before commit the 'RISC-V: Update CSR to privileged spec 1.11.', so based on your original email I was expecting this to work - unfortunately I'm still seeing the same error here. Can you confirm which version of GDB you see this passing with. Thanks, Andrew