Re: [PATCH 3/3][gdb/testsuite] Warn about leaked global array

Tom de Vries
2020-06-02T13:09:05Z

On 22-05-2020 22:15, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>
> Tom> So, since a global name in one test-case can leak to another
> Tom> test-case, setting a global name in one test-case can result in
> Tom> a tcl error in another test-case that reuses the name in a different
> Tom> way.
>
> Tom> Warn about leaking a global array from a test-case.
>
> This seems fine to me.
>
> Tom> Also, add a possibility to skip the warning in a given test-case using
> Tom> variable gdb_skip_check_global_vars, and use it in gdb.mi/mi2-var-child.exp
> Tom> and gdb.mi/mi-var-cp.exp.
>
> Is that because these tests are still buggy in this way, or something
> deeper?

The former.

Thanks,
- Tom