From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hera.aquilenet.fr (hera.aquilenet.fr [185.233.100.1]) by sourceware.org (Postfix) with ESMTPS id B626B386EC42 for ; Sun, 31 May 2020 07:42:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B626B386EC42 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=samuel.thibault@gnu.org Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id C66424D5; Sun, 31 May 2020 09:42:58 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZrIcGSUrxwHw; Sun, 31 May 2020 09:42:57 +0200 (CEST) Received: from function (lfbn-bor-1-797-11.w86-234.abo.wanadoo.fr [86.234.239.11]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 792023D1; Sun, 31 May 2020 09:42:57 +0200 (CEST) Received: from samy by function with local (Exim 4.93) (envelope-from ) id 1jfIcS-00BT7k-8N; Sun, 31 May 2020 09:42:56 +0200 Date: Sun, 31 May 2020 09:42:56 +0200 From: Samuel Thibault To: Simon Marchi Cc: gdb-patches@sourceware.org, Thomas Schwinge , thomas@schwinge.name, bug-hurd@gnu.org Subject: Re: [PATCH] gnu-nat: Move local functions inside gnu_nat_target class Message-ID: <20200531074256.ronlpeold7aiywec@function> Mail-Followup-To: Simon Marchi , gdb-patches@sourceware.org, Thomas Schwinge , thomas@schwinge.name, bug-hurd@gnu.org References: <20200530180459.ixrex5ui7apzpt4u@function> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_SOFTFAIL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 May 2020 07:43:02 -0000 Simon Marchi, le sam. 30 mai 2020 19:59:03 -0400, a ecrit: > On 2020-05-30 2:04 p.m., Samuel Thibault wrote: > > This allows to have the process_stratum_target object at hand for future use in > > the gdb API, and only use gnu_target from external calls. > > > > gdb/Changelog: > > > > * gnu-nat.h (inf_validate_procs, inf_suspend, inf_set_traced, > > steal_exc_port, proc_get_state, inf_clear_wait, inf_cleanup, > > inf_startup, inf_update_suspends, inf_set_pid, inf_steal_exc_ports, > > inf_validate_procinfo, inf_validate_task_sc, inf_restore_exc_ports, > > inf_set_threads_resume_sc, inf_set_threads_resume_sc_for_signal_thread, > > inf_resume, inf_set_step_thread, inf_detach, inf_attach, inf_signal, > > inf_continue, make_proc, proc_abort, _proc_free, proc_update_sc, > > proc_get_exception_port, proc_set_exception_port, _proc_get_exc_port, > > proc_steal_exc_port, proc_restore_exc_port, proc_trace): Move functions > > to gnu_nat_target class. > > * gnu-nat.c: Likewise. > > (inf_update_procs, S_proc_wait_reply, set_task_pause_cmd, > > set_task_exc_port_cmd, set_signals_cmd, set_thread_pause_cmd, > > set_thread_exc_port_cmd): Call inf_validate_procs through gnu_target > > object. > > (gnu_nat_target::create_inferior, gnu_nat_target::detach): Pass `this' > > instead of `gnu_target'. > > Thanks, this LGTM, I think it's a good step forward. Applied, thanks! Samuel