From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hera.aquilenet.fr (hera.aquilenet.fr [IPv6:2a0c:e300::1]) by sourceware.org (Postfix) with ESMTPS id 5D5613851C11 for ; Sat, 30 May 2020 15:32:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5D5613851C11 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=samuel.thibault@gnu.org Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id B804F455A; Sat, 30 May 2020 17:32:16 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cT6PYe3iOIzd; Sat, 30 May 2020 17:32:15 +0200 (CEST) Received: from function (lfbn-bor-1-797-11.w86-234.abo.wanadoo.fr [86.234.239.11]) by hera.aquilenet.fr (Postfix) with ESMTPSA id E4E6B414F; Sat, 30 May 2020 17:32:14 +0200 (CEST) Received: from samy by function with local (Exim 4.93) (envelope-from ) id 1jf3T3-00A7vK-CA; Sat, 30 May 2020 17:32:13 +0200 Date: Sat, 30 May 2020 17:32:13 +0200 From: Samuel Thibault To: Simon Marchi Cc: gdb-patches@sourceware.org, Thomas Schwinge , thomas@schwinge.name, bug-hurd@gnu.org Subject: Re: [PATCHv2 3/7] hurd: make function cast stronger Message-ID: <20200530153213.fcl5cqeescdqs6xv@function> Mail-Followup-To: Simon Marchi , gdb-patches@sourceware.org, Thomas Schwinge , thomas@schwinge.name, bug-hurd@gnu.org References: <20200529220049.gm7vt7gvtw7if6lg@function> <20200529220153.63gej54cam7itzmk@function> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_SOFTFAIL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 May 2020 15:32:19 -0000 Simon Marchi, le sam. 30 mai 2020 10:47:50 -0400, a ecrit: > On 2020-05-29 6:01 p.m., Samuel Thibault wrote: > > process_reply_S.c:104:23: error: function called through a non-compatible type [-Werror] > > 104 | OutP->RetCode = (*(kern_return_t (*)(mach_port_t, kern_return_t)) S_proc_setmsgport_reply) (In0P->Head.msgh_request_port, In0P- > > > > gdb/ChangeLog: > > > > 2020-05-29 Samuel Thibault > > > > * reply_mig_hack.awk (Error return): Cast function through > > void *, to bypass compiler function call check. > > If you are silencing a compiler warning, please explain why it is safe to do so. It is not actually safe, as explained by the comment above the changed lines, but as explained by the comment above really fixing it is very far from trivial. In my repo I have added “ As the existing comment says, it is in general not safe to drop some parameters like this, but this is the error handling case, where the called function does not actually read them, and mig is currently planned to be used on i386 and x86_64 only, where this is not a problem. As the existing comment says, fixing it properly would be far from trivial: we can't just pass 0 for them, as they might not be scalar. ” Is that enough of an explanation for the changelog? Samuel