From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <samuel.thibault@gnu.org>
Received: from hera.aquilenet.fr (hera.aquilenet.fr [185.233.100.1])
 by sourceware.org (Postfix) with ESMTPS id 8DE7A3851C2C
 for <gdb-patches@sourceware.org>; Fri, 29 May 2020 22:04:56 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8DE7A3851C2C
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=gnu.org
Authentication-Results: sourceware.org;
 spf=fail smtp.mailfrom=samuel.thibault@gnu.org
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id A1662D669;
 Sat, 30 May 2020 00:04:55 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at aquilenet.fr
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id Dvx7XeGxBUu9; Sat, 30 May 2020 00:04:54 +0200 (CEST)
Received: from function (lfbn-bor-1-797-11.w86-234.abo.wanadoo.fr
 [86.234.239.11])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id A26E67886;
 Sat, 30 May 2020 00:04:54 +0200 (CEST)
Received: from samy by function with local (Exim 4.93)
 (envelope-from <samuel.thibault@gnu.org>)
 id 1jen7W-008KI6-06; Sat, 30 May 2020 00:04:54 +0200
Date: Sat, 30 May 2020 00:04:53 +0200
From: Samuel Thibault <samuel.thibault@gnu.org>
To: gdb-patches@sourceware.org, Simon Marchi <simark@simark.ca>
Cc: Thomas Schwinge <thomas@codesourcery.com>, thomas@schwinge.name,
 bug-hurd@gnu.org
Subject: [PATCHv2 7/7] hurd: fix pushing target on inferior creation
Message-ID: <20200529220453.2t2oje5uqebxgovs@function>
Mail-Followup-To: gdb-patches@sourceware.org, Simon Marchi <simark@simark.ca>,
 Thomas Schwinge <thomas@codesourcery.com>, thomas@schwinge.name,
 bug-hurd@gnu.org
References: <20200529220049.gm7vt7gvtw7if6lg@function>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200529220049.gm7vt7gvtw7if6lg@function>
User-Agent: NeoMutt/20170609 (1.8.3)
X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_PASS, SPF_SOFTFAIL,
 TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 29 May 2020 22:04:57 -0000

This fixes creating inferiors, which was broken since 5b6d1e4fa ('Multi-target support')

gdb/ChangeLog:

2020-05-29  Samuel Thibault  <samuel.thibault@ens-lyon.org>

	* gnu-nat.c (gnu_nat_target::create_inferior): Move push_target call
	before fork_inferior call. Avoid calling it if target_is_pushed returns false.

---
v2: Added to patch series.

Index: binutils-gdb/gdb/gnu-nat.c
===================================================================
--- binutils-gdb.orig/gdb/gnu-nat.c
+++ binutils-gdb/gdb/gnu-nat.c
@@ -2146,6 +2146,9 @@ gnu_nat_target::create_inferior (const c
 
   inf_debug (inf, "creating inferior");
 
+  if (!target_is_pushed (this))
+    push_target (this);
+
   pid = fork_inferior (exec_file, allargs, env, gnu_ptrace_me,
                        NULL, NULL, NULL, NULL);
 
@@ -2159,8 +2162,6 @@ gnu_nat_target::create_inferior (const c
 
   inf_attach (inf, pid);
 
-  push_target (this);
-
   inf->pending_execs = 1;
   inf->nomsg = 1;
   inf->traced = 1;