From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sonic304-22.consmr.mail.ir2.yahoo.com (sonic304-22.consmr.mail.ir2.yahoo.com [77.238.179.147]) by sourceware.org (Postfix) with ESMTPS id 49791388E83D for ; Mon, 25 May 2020 18:57:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 49791388E83D X-YMail-OSG: wu1B0HQVM1kA3sKD.Kc.zMq_WWOPjmJKbBSN0g4JQzNFrIh7cipuS100iEYugrR OB_4OQe64J6nU2rnlK97aat6N2tQHHFoXm3q8XilXLuSRxBV1qdJ_hPOFm72sxqHp4nwMsmOqwbb oHkhanTtQmgE4Vsrx_7uIQBh1kzuYkZePazhz4C6wjYL609eLQhLtKm3rM7rrVwjARZE6xqtyje9 _5dp5y6es9fM.9PgMJyn1lx9XJX7_yXJIhghlhgRyPUN39FAj_dAhkHWw8rR3DIORsfwH56DkcSO n32ZHXoIa3ZT2aFJ9KqLs_nQS0zMP3s0ssyyBt2iuOTMERm02nVYOWnoRzr6I9VNDbMsWcbiMpeC DTyZF3EtBfEYoOMspgH4puC4371qeG8OskF6BlP91KbTijB9_.AmcZF9gbORHAlsM_qGmJpdej4A Gug9sRhk9e7zQzaZdAAiAT2Vm_Qav_77.O5zd7jhJV387jnAdQK4YwWTCOlx6MOnQZl9Ac7yKEuW wH.P5oXzeq4TfAmJUs5wuauriJ1IoyYT.t6n.uxvtVmbmeGraOgnNQXZ6ogfPbi7h11r3h02ft2o pI1RyaMQm_jlJouMxVk53jRX4tZoxrLFKWFiuIWlEFeu8qYeXyybWsrLICA_Z6kw_sTOWEpiqUSL idIpSJ5_vOvLTSD1Gpdv1fUM9QqLk_.1iwwVRuCh5beChn4pBPmOMNznbBmCLd6TgrSzAXlgM490 9Qby9VasTtTxmlnCCUQ_P1441BX2mmzJzK61fhmnjnKdQj7W4ZCPTS1AkLlvfItm3hC9MyhElJPd vib5cA7A_gvcsLoTBXYSzyhNERVzM5z1Gr.cb60OFHfHpAjfBscN9cHWvjGsHrOZ9fQfqflMLlFA surRVLx3wo89IL2zw91ofnsitfQwX3iyXiFz1nVn_rV2ePOpec5hkLwXD4A2NspUlir2J.hCZZwK Leu4xcZbRptwoASVq9Ut.fNrZ_SRiI5jOaU_huCzkl.Yoe39bPRO79EMI9zV6e7LoJmengrXG37v zRXHJiwawb3ghQVkyUSS5wcsBUbTpCTzV0a1u1X0ZgyCp1fQqKMo_ByEztHgIocHgtXjBi.wyglr b8AoCijpd30AF1buaD4f20SMm44pQqkpJ5IpEj1YcL3T73LMxrwtjF0vbOPFmXv0WNdJOxE2yDN_ qwvKM1pJW2MxY2_okdzDNdBVHOzNYjvOVHMkObPFeEq5evh0iAfVTAU1etUwOw1jVRgNs63QMFJu sFCifYPMR_jwm8EF2SpPXyLZPUn_joqFXlrdX4oS2lupmJzbICpXyl1QwX3qDNLWbOzG2AhUx8Nc Qs40cUW8GqotjOY.ANa1jcKbGEHWVDJt9IA8jYxZibHH1XxwUQvifbpAnZvsqU6eXx63uDgb4LN7 76g9DOwtX3lymE_zHUN167vp7_VV56Ww- Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.ir2.yahoo.com with HTTP; Mon, 25 May 2020 18:57:32 +0000 Received: by smtp423.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 8e39fad2073e4e08fe0b9c0b29120b31; Mon, 25 May 2020 18:57:31 +0000 (UTC) From: Hannes Domani To: gdb-patches@sourceware.org Subject: [PATCH 1/7] Fix function argument and return value locations Date: Mon, 25 May 2020 20:56:53 +0200 Message-Id: <20200525185659.59346-2-ssbssa@yahoo.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200525185659.59346-1-ssbssa@yahoo.de> References: <20200525185659.59346-1-ssbssa@yahoo.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Antivirus: Avast (VPS 200524-0, 05/24/2020), Outbound message X-Antivirus-Status: Clean X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SCC_5_SHORT_WORD_LINES, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 May 2020 18:57:43 -0000 Fixes these testsuite fails on Windows: FAIL: gdb.base/callfuncs.exp: p t_float_complex_values(fc1, fc2) FAIL: gdb.base/callfuncs.exp: p t_float_complex_many_args(fc1, fc2, fc3, fc4, fc1, fc2, fc3, fc4, fc1, fc2, fc3, fc4, fc1, fc2, fc3, fc4) FAIL: gdb.base/callfuncs.exp: noproto: p t_float_complex_values(fc1, fc2) FAIL: gdb.base/callfuncs.exp: noproto: p t_float_complex_many_args(fc1, fc2, fc3, fc4, fc1, fc2, fc3, fc4, fc1, fc2, fc3, fc4, fc1, fc2, fc3, fc4) FAIL: gdb.base/call-sc.exp: p/c fun(); call call-sc-tld FAIL: gdb.base/call-sc.exp: advance to fun for return; return call-sc-tld FAIL: gdb.base/call-sc.exp: zed L for return; return call-sc-tld FAIL: gdb.base/call-sc.exp: return foo; return call-sc-tld FAIL: gdb.base/call-sc.exp: return foo; synchronize pc to main() for 'call-sc-tld' FAIL: gdb.base/call-sc.exp: return foo; synchronize pc to main() for 'call-sc-tld' FAIL: gdb.base/call-sc.exp: advance to fun for finish; return call-sc-tld FAIL: gdb.base/call-sc.exp: zed L for finish; return call-sc-tld FAIL: gdb.base/call-sc.exp: finish foo; return call-sc-tld (the program is no longer running) FAIL: gdb.base/call-sc.exp: value foo finished; return call-sc-tld For function arguments (callfuncs.exp), only TYPE_CODE_COMPLEX was missing in the types passed via XMM registers. For return values, there were a lot more issues: - TYPE_CODE_DECFLOAT is NOT returned via XMM0. - long double is NOT returned via XMM0. - but __int128 IS returned via XMM0. - the comments for TYPE_CODE_FLT state that __m128, __m128i and __m128d are returned by XMM0, and this is correct, but it doesn't actually check for them, because they are TYPE_CODE_ARRAY with TYPE_VECTOR So I had to add TYPE_CODE_DECFLOAT to the arguments passed via XMM register, but I had to remove it from the values returned via XMM0 register. gdb/ChangeLog: 2020-05-25 Hannes Domani * amd64-windows-tdep.c (amd64_windows_passed_by_xmm_register): Add TYPE_CODE_COMPLEX. (amd64_windows_return_value): Fix types returned via XMM0. gdb/testsuite/ChangeLog: 2020-05-25 Hannes Domani * gdb.base/call-sc.c: Fix return struct on stack test case. * gdb.base/call-sc.exp: Likewise. --- gdb/amd64-windows-tdep.c | 23 ++++++++++++++++++----- gdb/testsuite/gdb.base/call-sc.c | 6 +++++- gdb/testsuite/gdb.base/call-sc.exp | 13 +++++++++++++ 3 files changed, 36 insertions(+), 6 deletions(-) diff --git a/gdb/amd64-windows-tdep.c b/gdb/amd64-windows-tdep.c index 487dfd45fc..db9845203f 100644 --- a/gdb/amd64-windows-tdep.c +++ b/gdb/amd64-windows-tdep.c @@ -77,7 +77,8 @@ static int amd64_windows_passed_by_xmm_register (struct type *type) { return ((type->code () == TYPE_CODE_FLT - || type->code () == TYPE_CODE_DECFLOAT) + || type->code () == TYPE_CODE_DECFLOAT + || type->code () == TYPE_CODE_COMPLEX) && (TYPE_LENGTH (type) == 4 || TYPE_LENGTH (type) == 8)); } @@ -299,17 +300,29 @@ amd64_windows_return_value (struct gdbarch *gdbarch, struct value *function, switch (type->code ()) { case TYPE_CODE_FLT: - case TYPE_CODE_DECFLOAT: - /* __m128, __m128i, __m128d, floats, and doubles are returned - via XMM0. */ - if (len == 4 || len == 8 || len == 16) + /* floats, and doubles are returned via XMM0. */ + if (len == 4 || len == 8) regnum = AMD64_XMM0_REGNUM; break; + case TYPE_CODE_ARRAY: + /* __m128, __m128i and __m128d are returned via XMM0. */ + if (TYPE_VECTOR (type) && len == 16) + { + enum type_code code = TYPE_TARGET_TYPE (type)->code (); + if (code == TYPE_CODE_INT || code == TYPE_CODE_FLT) + { + regnum = AMD64_XMM0_REGNUM; + break; + } + } + /* fall through */ default: /* All other values that are 1, 2, 4 or 8 bytes long are returned via RAX. */ if (len == 1 || len == 2 || len == 4 || len == 8) regnum = AMD64_RAX_REGNUM; + else if (len == 16 && type->code () == TYPE_CODE_INT) + regnum = AMD64_XMM0_REGNUM; break; } diff --git a/gdb/testsuite/gdb.base/call-sc.c b/gdb/testsuite/gdb.base/call-sc.c index ba80576ac3..eb140cd9cf 100644 --- a/gdb/testsuite/gdb.base/call-sc.c +++ b/gdb/testsuite/gdb.base/call-sc.c @@ -35,6 +35,7 @@ typedef t T; #endif T foo = '1', L; +T init = '9'; T fun() { @@ -55,7 +56,10 @@ int main() { int i; - Fun(foo); + /* Use a different initial value then is later used in the + "value foo returned" test, so in case the struct is then returned + on the stack, it doesn't have the correct value by accident. */ + Fun(init); /* An infinite loop that first clears all the variables and then calls the function. This "hack" is to make re-testing easier - diff --git a/gdb/testsuite/gdb.base/call-sc.exp b/gdb/testsuite/gdb.base/call-sc.exp index 719000435a..9697c5ac24 100644 --- a/gdb/testsuite/gdb.base/call-sc.exp +++ b/gdb/testsuite/gdb.base/call-sc.exp @@ -291,6 +291,19 @@ proc test_scalar_returns { } { fail "${test}" } } + -re " = 57 .*${gdb_prompt} $" { + if $return_value_unknown { + # The struct return case. + # The return value is stored on the stack, and since GDB + # didn't override it, it still has value that was stored + # there in the earlier Foo(init) call. + pass "${test}" + } else { + # This contradicts the above claim that GDB knew + # the location of the return-value. + fail "${test}" + } + } -re ".*${gdb_prompt} $" { if $return_value_unimplemented { # What a suprize. The architecture hasn't implemented -- 2.26.2