From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by sourceware.org (Postfix) with ESMTPS id B4B993858D35; Wed, 20 May 2020 01:51:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B4B993858D35 Received: by mail-pj1-x1031.google.com with SMTP id ci21so524074pjb.3; Tue, 19 May 2020 18:51:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=EujzQ+g5RHeZiB6zTX2qw+vC9UHJ5goTNWnnC0Z/r9c=; b=gK8NnB9sPy9ZTv0qDgoi8p4ohzexnfuOWuzNfet3vt1J40XCfWtH2gn1HUUJNlMM6Z c7/IFwo4wIEPU9p1uuych5E9QeO1ELuKVNXvmKTIc3Z73jvIhsK3DKZ81qHIcN+LrHPw NmQ9gRcbKdR6svvXgivwBk48ykVLIKAWtvxI5bXYQ0uWVfsFR6ajQ5px6QkNnuGjgzNn kcTuvGlOoTc9FPvxil4Tbr9xNKs1+Gf6keUgOjFVyhTmrZLy/HpxhJCDe23SxibkcoP9 PbDa6Ao/rJ9yEeuWG2ckfXwQnbKhIthv4vKmf4mmE2Un7eVCsNth72ipRBTpgCZKG9B1 Yo/w== X-Gm-Message-State: AOAM533euP2s0uAqZp9lf7PeIrMmpPHa8apB6MBjuXWPMwYQyQCH+xtc doJvIWYactxZ0Ya3x55Xp9MvZ/OL/ug= X-Google-Smtp-Source: ABdhPJzX8qic+IKg+ovRI0qdJzg7vEzUvqtre3KppMMPmLFaefp3aEQvU26s6ybUgfeKQyeyYCs/FA== X-Received: by 2002:a17:90a:5802:: with SMTP id h2mr2294529pji.221.1589939486920; Tue, 19 May 2020 18:51:26 -0700 (PDT) Received: from bubble.grove.modra.org ([2406:3400:51d:8cc0:9c3e:9766:b439:ff7f]) by smtp.gmail.com with ESMTPSA id q25sm604338pfh.94.2020.05.19.18.51.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 18:51:26 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 1D38F88A37; Wed, 20 May 2020 11:21:22 +0930 (ACST) Date: Wed, 20 May 2020 11:21:22 +0930 From: Alan Modra To: Simon Marchi Cc: binutils@sourceware.org, gdb-patches@sourceware.org Subject: Re: PR25993, read of freed memory Message-ID: <20200520015121.GA11251@bubble.grove.modra.org> References: <20200519043205.GT1088@bubble.grove.modra.org> <111d8c5d-d615-e0ae-36de-519c43a51139@simark.ca> <20200519234014.GA16809@bubble.grove.modra.org> <6de2c911-78b4-4a8e-6b40-5166211ee07a@simark.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6de2c911-78b4-4a8e-6b40-5166211ee07a@simark.ca> User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 May 2020 01:51:29 -0000 On Tue, May 19, 2020 at 08:19:08PM -0400, Simon Marchi wrote: > That LGTM for the GDB side, but I get a build failure in bfd/archive.c. I think > bfd-in2.h needs to be regenerated? Or maybe in BFD you don't typically include > re-generated files in your patches? Yes, I stripped that out when posting the patch. Thanks for reviewing! -- Alan Modra Australia Development Lab, IBM