From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH v2 0/5] Fix BZ 25631 - core file memory access problem
Date: Wed, 13 May 2020 10:11:50 -0700 [thread overview]
Message-ID: <20200513171155.645761-1-kevinb@redhat.com> (raw)
This series fixes a bug with accessing memory from core files.
The bug can be viewed here...
https://sourceware.org/bugzilla/show_bug.cgi?id=25631
...though I also provide similar details in part 4 of this series.
It incorporates suggestions made by Keith and Pedro in their reviews.
The biggest change from v1 is that the section splitting code that
I introduced in v1 has been entirely removed. Instead, I now pass
a predicate to section_table_xfer_memory as suggested by Pedro.
Pedro has asked me to write another test case for a problem
that he found while reviewing v1. I will attempt to do that, but I
wanted to post this patch series so that review can start sooner.
If I manage to create a good test, I'll post that separately.
Kevin Buettner (5):
Remove hack for GDB which sets the section size to 0
Adjust corefile.exp test to show regression after bfd hack removal
section_table_xfer_memory: Replace section name with callback
predicate
Provide access to non SEC_HAS_CONTENTS core file sections
Test ability to access unwritten-to mmap data in core file
bfd/elf.c | 8 -----
gdb/bfd-target.c | 3 +-
gdb/corelow.c | 48 ++++++++++++++++++++++++-----
gdb/exec.c | 8 ++---
gdb/exec.h | 13 ++++++--
gdb/target.c | 18 ++++++++---
gdb/testsuite/gdb.base/corefile.exp | 6 ++++
gdb/testsuite/gdb.base/coremaker.c | 16 ++++++++++
8 files changed, 91 insertions(+), 29 deletions(-)
--
2.25.4
next reply other threads:[~2020-05-13 17:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 17:11 Kevin Buettner [this message]
2020-05-13 17:11 ` [PATCH v2 1/5] Remove hack for GDB which sets the section size to 0 Kevin Buettner
2020-05-13 17:11 ` [PATCH v2 2/5] Adjust corefile.exp test to show regression after bfd hack removal Kevin Buettner
2020-05-20 16:24 ` Pedro Alves
2020-05-13 17:11 ` [PATCH v2 3/5] section_table_xfer_memory: Replace section name with callback predicate Kevin Buettner
2020-05-20 16:33 ` Pedro Alves
2020-05-13 17:11 ` [PATCH v2 4/5] Provide access to non SEC_HAS_CONTENTS core file sections Kevin Buettner
2020-05-20 16:45 ` Pedro Alves
2020-05-21 7:50 ` Kevin Buettner
2020-05-21 12:40 ` Pedro Alves
2020-05-21 14:23 ` Pedro Alves
2020-05-21 15:09 ` Kevin Buettner
2020-05-21 16:28 ` Pedro Alves
2020-05-21 17:06 ` Pedro Alves
2020-05-13 17:11 ` [PATCH v2 5/5] Test ability to access unwritten-to mmap data in core file Kevin Buettner
2020-05-20 16:46 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200513171155.645761-1-kevinb@redhat.com \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox