Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [committed][gdb/testsuite] Fix duplicate test-names in gdb.multi
Date: Tue, 12 May 2020 11:18:32 +0200	[thread overview]
Message-ID: <20200512091831.GA2302@delia> (raw)

Hi,

In gdb.multi we have:
...
DUPLICATE: gdb.multi/multi-term-settings.exp: \
  inf1_how=run: inf2_how=run: info inferiors
DUPLICATE: gdb.multi/multi-term-settings.exp: \
  inf1_how=run: inf2_how=attach: info inferiors
DUPLICATE: gdb.multi/multi-term-settings.exp: \
  inf1_how=run: inf2_how=tty: info inferiors
DUPLICATE: gdb.multi/multi-term-settings.exp: \
  inf1_how=attach: inf2_how=run: info inferiors
DUPLICATE: gdb.multi/multi-term-settings.exp: \
  inf1_how=attach: inf2_how=attach: attach
DUPLICATE: gdb.multi/multi-term-settings.exp: \
  inf1_how=attach: inf2_how=attach: info inferiors
DUPLICATE: gdb.multi/multi-term-settings.exp: \
  inf1_how=attach: inf2_how=tty: info inferiors
DUPLICATE: gdb.multi/multi-term-settings.exp: \
  inf1_how=tty: inf2_how=run: info inferiors
DUPLICATE: gdb.multi/multi-term-settings.exp: \
  inf1_how=tty: inf2_how=attach: info inferiors
DUPLICATE: gdb.multi/multi-term-settings.exp: \
  inf1_how=tty: inf2_how=tty: tty TTY
DUPLICATE: gdb.multi/multi-term-settings.exp: \
  inf1_how=tty: inf2_how=tty: info inferiors
...

Fix these using with_test_prefix.

Tested on x86_64-linux.

Committed to trunk.

Thanks,
- Tom

[gdb/testsuite] Fix duplicate test-names in gdb.multi

gdb/testsuite/ChangeLog:

2020-05-12  Tom de Vries  <tdevries@suse.de>

	* gdb.multi/multi-term-settings.exp: Use with_test_prefix.

---
 gdb/testsuite/gdb.multi/multi-term-settings.exp | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/gdb/testsuite/gdb.multi/multi-term-settings.exp b/gdb/testsuite/gdb.multi/multi-term-settings.exp
index dafbb1e5f3..aa467e3b41 100644
--- a/gdb/testsuite/gdb.multi/multi-term-settings.exp
+++ b/gdb/testsuite/gdb.multi/multi-term-settings.exp
@@ -125,7 +125,9 @@ proc coretest {inf1_how inf2_how} {
 
     clean_restart $binfile
 
-    set inf1_spawn_id [create_inferior 1 $inf1_how]
+    with_test_prefix "inf1" {
+	set inf1_spawn_id [create_inferior 1 $inf1_how]
+    }
 
     set num 2
     gdb_test "add-inferior" "Added inferior $num.*" \
@@ -134,7 +136,9 @@ proc coretest {inf1_how inf2_how} {
 	"switch to inferior $num"
     gdb_file_cmd ${binfile}
 
-    set inf2_spawn_id [create_inferior 2 $inf2_how]
+    with_test_prefix "inf2" {
+	set inf2_spawn_id [create_inferior 2 $inf2_how]
+    }
 
     gdb_test_no_output "set schedule-multiple on"
 
@@ -218,8 +222,10 @@ proc coretest {inf1_how inf2_how} {
     }
 
     # Useful for debugging in case the Ctrl-C above fails.
-    gdb_test "info inferiors"
-    gdb_test "info threads"
+    with_test_prefix "final" {
+	gdb_test "info inferiors"
+	gdb_test "info threads"
+    }
 }
 
 set how_modes {"run" "attach" "tty"}


                 reply	other threads:[~2020-05-12  9:18 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200512091831.GA2302@delia \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox