From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [committed][gdb/testsuite] Fix duplicate test-names in gdb.ada
Date: Tue, 12 May 2020 11:06:01 +0200 [thread overview]
Message-ID: <20200512090600.GA32193@delia> (raw)
Hi,
In gdb.ada we have these duplicate test-names:
...
DUPLICATE: gdb.ada/catch_ex.exp: continuing to program completion
DUPLICATE: gdb.ada/mi_catch_ex.exp: breakpoint at main
DUPLICATE: gdb.ada/mi_catch_ex.exp: mi runto main
DUPLICATE: gdb.ada/mi_catch_ex_hand.exp: breakpoint at main
DUPLICATE: gdb.ada/mi_catch_ex_hand.exp: mi runto main
...
Fix these using with_test_prefix.
Tested on x86_64-linux.
Committed to trunk.
Thanks,
- Tom
[gdb/testsuite] Fix duplicate test-names in gdb.ada
gdb/testsuite/ChangeLog:
2020-05-12 Tom de Vries <tdevries@suse.de>
* gdb.ada/catch_ex.exp: Use with_test_prefix.
* gdb.ada/mi_catch_ex.exp: Same.
* gdb.ada/mi_catch_ex_hand.exp: Same.
---
gdb/testsuite/gdb.ada/catch_ex.exp | 9 +++++----
gdb/testsuite/gdb.ada/mi_catch_ex.exp | 16 ++++++++++------
gdb/testsuite/gdb.ada/mi_catch_ex_hand.exp | 16 ++++++++++------
3 files changed, 25 insertions(+), 16 deletions(-)
diff --git a/gdb/testsuite/gdb.ada/catch_ex.exp b/gdb/testsuite/gdb.ada/catch_ex.exp
index 5bdb63c8fc..7bb1c06f54 100644
--- a/gdb/testsuite/gdb.ada/catch_ex.exp
+++ b/gdb/testsuite/gdb.ada/catch_ex.exp
@@ -162,9 +162,10 @@ gdb_test "continue" \
"Continuing\.$eol$temp_catchpoint_msg$eol.*SPOT1" \
"continuing to temporary catchpoint"
-gdb_test "continue" \
- "Continuing\..*$inferior_exited_re.*" \
- "continuing to program completion"
-
+with_test_prefix "temporary catchpoint" {
+ gdb_test "continue" \
+ "Continuing\..*$inferior_exited_re.*" \
+ "continuing to program completion"
+}
diff --git a/gdb/testsuite/gdb.ada/mi_catch_ex.exp b/gdb/testsuite/gdb.ada/mi_catch_ex.exp
index 60a5f6f19e..4b3e4f6f0b 100644
--- a/gdb/testsuite/gdb.ada/mi_catch_ex.exp
+++ b/gdb/testsuite/gdb.ada/mi_catch_ex.exp
@@ -69,9 +69,11 @@ mi_gdb_load ${binfile}
# 1. Try catching all exceptions. #
####################################
-if ![mi_run_to_main] then {
- fail "cannot run to main, testcase aborted"
- return 0
+with_test_prefix "scenario 1" {
+ if ![mi_run_to_main] then {
+ fail "cannot run to main, testcase aborted"
+ return 0
+ }
}
mi_gdb_test "-catch-exception" \
@@ -125,9 +127,11 @@ continue_to_exception \
# - continue, we should see the unhandled Constrait_Error exception
# - continue, the program exits.
-if ![mi_run_to_main] then {
- fail "cannot run to main, testcase aborted"
- return 0
+with_test_prefix "scenario 2" {
+ if ![mi_run_to_main] then {
+ fail "cannot run to main, testcase aborted"
+ return 0
+ }
}
mi_gdb_test "-catch-exception -e Program_Error" \
diff --git a/gdb/testsuite/gdb.ada/mi_catch_ex_hand.exp b/gdb/testsuite/gdb.ada/mi_catch_ex_hand.exp
index 159b22173a..59c8a10085 100644
--- a/gdb/testsuite/gdb.ada/mi_catch_ex_hand.exp
+++ b/gdb/testsuite/gdb.ada/mi_catch_ex_hand.exp
@@ -64,9 +64,11 @@ if [mi_gdb_start] {
# 1. Try catching all exceptions handlers. #
#############################################
-if ![mi_run_to_main] then {
- fail "cannot run to main, testcase aborted"
- return 0
+with_test_prefix "scenario 1" {
+ if ![mi_run_to_main] then {
+ fail "cannot run to main, testcase aborted"
+ return 0
+ }
}
mi_gdb_test "-catch-handlers" \
@@ -114,9 +116,11 @@ continue_to_exception_handler \
# - continue, we should not stop at the Program_Error exception handler
# but exit instead.
-if ![mi_run_to_main] then {
- fail "cannot run to main, testcase aborted"
- return 0
+with_test_prefix "scenario 2" {
+ if ![mi_run_to_main] then {
+ fail "cannot run to main, testcase aborted"
+ return 0
+ }
}
mi_gdb_test "-catch-handlers -e Constraint_Error" \
reply other threads:[~2020-05-12 9:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512090600.GA32193@delia \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox