From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id CDBA8386F824 for ; Sat, 2 May 2020 07:51:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CDBA8386F824 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 55008AC46 for ; Sat, 2 May 2020 07:51:31 +0000 (UTC) Date: Sat, 2 May 2020 09:51:29 +0200 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [committed][gdb/testsuite] Update psym-external-decl.exp for gcc-10/clang Message-ID: <20200502075127.GA21196@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-28.0 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 May 2020 07:51:33 -0000 Hi, When running test-case gdb.base/psym-external-decl.exp with gcc-10, we have: ... (gdb) print aaa^M 'aaa' has unknown type; cast it to its declared type^M (gdb) FAIL: gdb.base/psym-external-decl.exp: print aaa ... With an an earlier version, gcc still emits the debug info for the declaration of aaa: ... <0>: Abbrev Number: 1 (DW_TAG_compile_unit) DW_AT_name : psym-external-decl.c <1>: Abbrev Number: 2 (DW_TAG_variable) DW_AT_name : aaa DW_AT_external : 1 DW_AT_declaration : 1 ... but with gcc-10 that's no longer the case. Fix the test-case by adding a use of aaa in psym-external-decl.c. That still doesn't work for clang, so skip test in that case. Tested with x86_64-linux, with gcc 7.5.0, gcc 10.0.0 and clang 5.0.2. Also tested by reverting corresponding fix and ensuring test-case still fails. Committed to trunk. Thanks, - Tom [gdb/testsuite] Update psym-external-decl.exp for gcc-10/clang gdb/testsuite/ChangeLog: 2020-05-02 Tom de Vries * gdb.base/psym-external-decl.c (main): Add use of variable aaa. --- gdb/testsuite/gdb.base/psym-external-decl.c | 2 +- gdb/testsuite/gdb.base/psym-external-decl.exp | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.base/psym-external-decl.c b/gdb/testsuite/gdb.base/psym-external-decl.c index 7a4b1077741..e2374327bde 100644 --- a/gdb/testsuite/gdb.base/psym-external-decl.c +++ b/gdb/testsuite/gdb.base/psym-external-decl.c @@ -20,6 +20,6 @@ extern int aaa; int main (void) { - return 0; + return aaa; } diff --git a/gdb/testsuite/gdb.base/psym-external-decl.exp b/gdb/testsuite/gdb.base/psym-external-decl.exp index bbcc2745755..d0388d5655e 100644 --- a/gdb/testsuite/gdb.base/psym-external-decl.exp +++ b/gdb/testsuite/gdb.base/psym-external-decl.exp @@ -15,6 +15,11 @@ standard_testfile .c psym-external-decl-2.c +get_compiler_info +if { [test_compiler_info "clang-*"] } { + return -1 +} + set srcfiles [list $srcfile $srcfile2] if { [build_executable_from_specs \