From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by sourceware.org (Postfix) with ESMTP id 97210386F44C for ; Sat, 2 May 2020 04:02:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 97210386F44C Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-355-wI5nFkXuPOCFrCSdQdF_6A-1; Sat, 02 May 2020 00:02:32 -0400 X-MC-Unique: wI5nFkXuPOCFrCSdQdF_6A-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5E8011895917; Sat, 2 May 2020 04:02:31 +0000 (UTC) Received: from f31-4.lan (ovpn-112-106.phx2.redhat.com [10.3.112.106]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 999C1605CB; Sat, 2 May 2020 04:02:30 +0000 (UTC) Date: Fri, 1 May 2020 21:02:29 -0700 From: Kevin Buettner To: Philippe Waroquiers via Gdb-patches Subject: Re: [PUSHED/OBVIOUS] Remove gdb-gdb.gdb breakpoint on disappeared function info_command. Message-ID: <20200501210229.5cb3950d@f31-4.lan> In-Reply-To: <20200501145451.20119-1-philippe.waroquiers@skynet.be> References: <20200501145451.20119-1-philippe.waroquiers@skynet.be> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 May 2020 04:02:37 -0000 On Fri, 1 May 2020 16:54:51 +0200 Philippe Waroquiers via Gdb-patches wrote: > The function info_command has disappeared, so this breakpoint does not > work anymore. > "info_command" was a function for the prefix command "info", > giving the list of "info" subcommands. > It is not very clear what the removed breakpoint and its associated > command list was supposed to do. > > Removed and pushed as obvious, after discussion with Tom. Thanks for doing this. I spent a few minutes looking at this. It was apparently introduced into the CVS repository by Stan Shebs on 1999-04-16. The patch in question is massive, nearly a million lines long. A bunch of ChangeLog files are imported. Actually, it seems likely that the entirety of the GDB sources was in this import. The earliest ChangeLog entry is June 28, 1998 and the latest is dated about a week prior to Stan's commit. The commit message was "Initial creation of sourceware repository". (There are a number of commits which use this same message.) I couldn't find any clue from the ChangeLog entries about why that break command was put into the .gdbinit file. It might be possible to figure out more precisely when it was introduced, but I didn't attempt this. I doubt that earlier imports would have any additional useful info not already in the ChangeLog entries that I did examine. Kevin