Re: [PATCH 0/4] gdb: Move construct_inferior_arguments to gdbsupport

Michael Weghorn
2020-05-12T15:50:45Z

On 07/05/2020 21.31, Simon Marchi wrote:
>> diff --git a/gdbsupport/common-inferior.cc b/gdbsupport/common-inferior.cc
>> index ed16e89a52..71b9a11e02 100644
>> --- a/gdbsupport/common-inferior.cc
>> +++ b/gdbsupport/common-inferior.cc
>> @@ -24,3 +24,126 @@
>> /* See common-inferior.h. */
>>
>> bool startup_with_shell = true;
>> +
>> +/* Compute command-line string given argument vector. This does the
>> + same shell processing as fork_inferior. */
>
> Let's just do a bit of spring cleaning and align this code with our current
> standards while moving it. Move the function comment to the .h, and in the.cc
> file write:
>
> /* See common-inferior.h. */
>
> Other than that, this patch LGTM.
>
> Simon
>

I've moved the comment in the new version,
https://sourceware.org/pipermail/gdb-patches/2020-May/168346.html

Michael