Re: [PATCH v5 1/9] gdb: Move construct_inferior_arguments to gdbsupport

Simon Marchi
2020-05-25T15:42:54Z

On 2020-05-20 12:21 p.m., Michael Weghorn via Gdb-patches wrote:
> This moves the function construct_inferior_arguments from
> gdb/inferior.h and gdb/infcmd.c to gdbsupport/common-inferior.{h,cc}.
> While at it, also move the function's comment to the header file
> to align with current standards.
>
> The intention is to use it from gdbserver in a follow-up commit.
>
> gdb/ChangeLog:
>
> 2020-05-13 Michael Weghorn <m.weghorn@posteo.de>
>
> * infcmd.c, inferior.h: (construct_inferior_arguments):
> Moved function from here to gdbsupport/common-inferior.{h,cc}
>
> gdbsupport/ChangeLog:
>
> w020-05-13 Michael Weghorn <m.weghorn@posteo.de>
>
> * common-inferior.h, common-inferior.cc: (construct_inferior_arguments):
> Move function here from gdb/infcmd.c, gdb/inferior.h

I've pushed the whole series, we can take a look at improving how inferior arguments
are passed to gdb_run_cmd as a separate change.

Thanks a lot for your contribution and perseverance!

Simon