Re: [PATCH 2/4] gdbserver: Don't add extra NULL to program args

Simon Marchi
2020-05-07T19:54:31Z

On 2020-04-29 7:16 a.m., Michael Weghorn via Gdb-patches wrote:
> The vector holding the program args is passed as a parameter
> to target_create_inferior, which then passes it to
> stringify_argv for all platforms, where any NULL entry in
> the vector is ignored, so there seems to be no reason
> to actually add one after all.
>
> (Since the intention is to replace uses of stringify_argv with
> construct_inferior_arguments in a follow-up commit and that
> function doesn't currently handle such NULL arguments, it
> would otherwise have to be extended.)

Thanks, this LGTM.

And a big thank you for writing informative commit messages up front, those
help a lot understand the need for your changes.

Simon