Re: [PATCH v5 1/9] gdb: Move construct_inferior_arguments to gdbsupport

Simon Marchi via Gdb-patches
2021-09-28T14:34:21Z

On 2020-05-26 02:17, Michael Weghorn wrote:
> On 25/05/2020 17.42, Simon Marchi wrote:
>> On 2020-05-20 12:21 p.m., Michael Weghorn via Gdb-patches wrote:
>>> This moves the function construct_inferior_arguments from
>>> gdb/inferior.h and gdb/infcmd.c to gdbsupport/common-inferior.{h,cc}.
>>> While at it, also move the function's comment to the header file
>>> to align with current standards.
>>>
>>> The intention is to use it from gdbserver in a follow-up commit.
>>>
>>> gdb/ChangeLog:
>>>
>>> 2020-05-13 Michael Weghorn <m.weghorn@posteo.de>
>>>
>>> * infcmd.c, inferior.h: (construct_inferior_arguments):
>>> Moved function from here to gdbsupport/common-inferior.{h,cc}
>>>
>>> gdbsupport/ChangeLog:
>>>
>>> w020-05-13 Michael Weghorn <m.weghorn@posteo.de>
>>>
>>> * common-inferior.h, common-inferior.cc: (construct_inferior_arguments):
>>> Move function here from gdb/infcmd.c, gdb/inferior.h
>>
>> I've pushed the whole series, we can take a look at improving how inferior arguments
>> are passed to gdb_run_cmd as a separate change.
>>
>> Thanks a lot for your contribution and perseverance!
>>
>> Simon
>
>
> Thanks for pushing and all help along the process!
>
> Michael
>

Hi Michael,

Can you take a look at this bug?

https://sourceware.org/bugzilla/show_bug.cgi?id=28392

Thanks,

Simon