From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by sourceware.org (Postfix) with ESMTPS id 5CCCC38930C3 for ; Wed, 29 Apr 2020 09:02:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5CCCC38930C3 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wr1-x429.google.com with SMTP id d17so1496231wrg.11 for ; Wed, 29 Apr 2020 02:02:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=oiE1ptw33znwvVOi93UdXkOdcttTb1pYkPdvXgxhiGI=; b=RoBOYlUTc6Jks8sbAEAgpDTUFS735ufilZlPx4//i5K4m7gERVH/74G0mmepnity9u L+/imNYIOz7oDL9Ole3es3jUeI9ucp54svKMm54mrtcneP3RwfT4932h+a2LDzhO52nk OvJFtMT0dIcQ9O0z3nFxUVrYXsZeTZoWunz6z6+CEEDujP0aS2vIAULrmZPSyzfCFexW jeE42R8xue3droRIIqu2ZLzRxscOd681SavR1i/tFnCV42ix5tQCf2HktpnzNyfVIhdk WcNI3WsyEWWOXtRvW1b+w59vrIk5e9p/y1keN3cinanHBSBgGVZD0KsLNXO2OXKY25IK NaYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oiE1ptw33znwvVOi93UdXkOdcttTb1pYkPdvXgxhiGI=; b=dRYRU2p+sG39JV/ZV4giQon+mr4NghNsuShB08cQH87joK4HlFRRukDjmPyypR1aIm 1CAls7LK/e+wUwSdKgUsW2QZ53UJAozTiqAv8v/O5Csobc54GDK6M2UFUbQgp4uQFYxG M1pNHeRjSLfxevAsab4kael5iAnlSO/1d8H22CJZUGeRv9Lkyks2yWT+Gzsa55ZNPcPD vHr09/FrpZoPjcveG7yn+K9oKj6eYembizGaZFO0me8ua/Pqry2nZ0Y1qsdZXjq2eOKZ E03kJpe62327+Fg0EPIJHqBZU2lVU1YnIO8kZ9XfIZqO1dqqppOE+RlT2mHantTuCB4m JDyg== X-Gm-Message-State: AGi0Pua4umhYvcLkUsTn/edFoDAKBDVhe17BCbPgD7NV59BhkPt4T4Qt EcOJxlp9WAtdFTFHVqg5qIJS8rka1LI= X-Google-Smtp-Source: APiQypLSqBaobYeRRJgYY49aItiGZJ+lXrTULGuYsq9toerwrwPkB54CYolrhcM8EaOnBLJzQVmtCg== X-Received: by 2002:adf:cd12:: with SMTP id w18mr38445373wrm.177.1588150939449; Wed, 29 Apr 2020 02:02:19 -0700 (PDT) Received: from localhost (host81-151-181-184.range81-151.btcentralplus.com. [81.151.181.184]) by smtp.gmail.com with ESMTPSA id m14sm28877462wrs.76.2020.04.29.02.02.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2020 02:02:18 -0700 (PDT) Date: Wed, 29 Apr 2020 10:02:16 +0100 From: Andrew Burgess To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [PATCHv2 0/3] Automatic detection of test name problems Message-ID: <20200429090216.GI3522@embecosm.com> References: <290d0de3-264b-9a60-487f-ff6b484c35f1@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <290d0de3-264b-9a60-487f-ff6b484c35f1@redhat.com> X-Operating-System: Linux/5.5.17-200.fc31.x86_64 (x86_64) X-Uptime: 10:01:27 up 8 days, 18:35, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Apr 2020 09:02:30 -0000 * Keith Seitz [2020-04-28 12:08:25 -0700]: > On 4/27/20 3:01 PM, Andrew Burgess wrote: > > Changes since v1: > > > > 1. Original patch #1 is now merged. > > > > 2. Functionality is now placed inside a namespace. > > > > 3. Better counting for multi-variant test runs, this is inline with > > how Dejagnu's muti-variant result counting works. > > > > 4. Use 'string first' instead of 'regexp'. > > > > 5. Reworded commit message on what is now patch #2. > > > > Further feedback welcome. > > Wow, that's almost a complete rewrite! While not what I was really > suggesting, I have to admit, a /big/ smile came to my face while > reading this. It is so nicely done! > > Thank you! > > Keith > > PS. As you know, IANAM, but you are, so I encourage you to approve > your patch. ;-) Thanks for your feedback, especially your TCL suggestions. I'll let the patch sit for a while to see if anyone else has any input. Thanks, Andrew