From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from barracuda.ebox.ca (barracuda.ebox.ca [96.127.255.19]) by sourceware.org (Postfix) with ESMTPS id 64C8C39858B3 for ; Tue, 28 Apr 2020 21:47:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 64C8C39858B3 X-ASG-Debug-ID: 1588110422-0c856e18f3114d0b0001-fS2M51 Received: from smtp.ebox.ca (smtp.ebox.ca [96.127.255.82]) by barracuda.ebox.ca with ESMTP id 8M8nPlITPcMHlocK (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 28 Apr 2020 17:47:02 -0400 (EDT) X-Barracuda-Envelope-From: simon.marchi@efficios.com X-Barracuda-RBL-Trusted-Forwarder: 96.127.255.82 Received: from localhost.localdomain (unknown [192.222.164.54]) by smtp.ebox.ca (Postfix) with ESMTP id 91E17441D64; Tue, 28 Apr 2020 17:47:02 -0400 (EDT) From: Simon Marchi X-Barracuda-Effective-Source-IP: 192-222-164-54.qc.cable.ebox.net[192.222.164.54] X-Barracuda-Apparent-Source-IP: 192.222.164.54 X-Barracuda-RBL-IP: 192.222.164.54 To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 6/7] gdb: fix shellcheck warnings SC2154 (referenced but not assigned) in gdbarch.sh Date: Tue, 28 Apr 2020 17:46:54 -0400 X-ASG-Orig-Subj: [PATCH 6/7] gdb: fix shellcheck warnings SC2154 (referenced but not assigned) in gdbarch.sh Message-Id: <20200428214655.3255454-7-simon.marchi@efficios.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200428214655.3255454-1-simon.marchi@efficios.com> References: <20200428214655.3255454-1-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Barracuda-Connect: smtp.ebox.ca[96.127.255.82] X-Barracuda-Start-Time: 1588110422 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://96.127.255.19:443/cgi-mod/mark.cgi X-Barracuda-Scan-Msg-Size: 2752 X-Virus-Scanned: by bsmtpd at ebox.ca X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=8.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.81496 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Spam-Status: No, score=-38.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_SOFTFAIL, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Apr 2020 21:47:06 -0000 Fix all instances of this kind of warning: In gdbarch.sh line 96: m ) staticdefault="${predefault}" ;; ^-----------^ SC2154: predefault is referenced but not assigned. These warnings appear because we are doing something a bit funky when reading the gdbarch fields. These variables are not assigned explicitly, but using some `eval` commands. I don't think there is so much we can fix about those warnings. To silence them, I've changed `${foo}` to `${foo:-}`. This tells the shell to substitute with an empty string if `foo` is not defined. This retains the current behavior, but the warnings go away. gdb/ChangeLog: * gdbarch.sh: Use ${foo:-} where shellcheck would report a "referenced but not assigned" warning. --- gdb/gdbarch.sh | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/gdb/gdbarch.sh b/gdb/gdbarch.sh index 4e4cc827b895..24f8cdfe90b0 100755 --- a/gdb/gdbarch.sh +++ b/gdb/gdbarch.sh @@ -75,7 +75,7 @@ ${line} EOF IFS="${OFS}" - if test -n "${garbage_at_eol}" + if test -n "${garbage_at_eol:-}" then echo "Garbage at end-of-line in ${line}" 1>&2 kill $$ @@ -93,19 +93,19 @@ EOF done case "${class}" in - m ) staticdefault="${predefault}" ;; + m ) staticdefault="${predefault:-}" ;; M ) staticdefault="0" ;; * ) test "${staticdefault}" || staticdefault=0 ;; esac case "${class}" in F | V | M ) - case "${invalid_p}" in + case "${invalid_p:-}" in "" ) if test -n "${predefault}" then #invalid_p="gdbarch->${function} == ${predefault}" - predicate="gdbarch->${function} != ${predefault}" + predicate="gdbarch->${function:-} != ${predefault}" elif class_is_variable_p then predicate="gdbarch->${function} != 0" @@ -139,7 +139,7 @@ EOF fallback_default_p () { - { [ -n "${postdefault}" ] && [ "x${invalid_p}" != "x0" ]; } \ + { [ -n "${postdefault:-}" ] && [ "x${invalid_p}" != "x0" ]; } \ || { [ -n "${predefault}" ] && [ "x${invalid_p}" = "x0" ]; } } @@ -1206,7 +1206,7 @@ exec > new-gdbarch.log function_list | while do_read do cat <= 2)\n" printf " fprintf_unfiltered (gdb_stdlog, \"gdbarch_%s called\\\\n\");\n" "$function" - if [ "x${actual}" = "x-" ] || [ "x${actual}" = "x" ] + if [ "x${actual:-}" = "x-" ] || [ "x${actual:-}" = "x" ] then if class_is_multiarch_p then -- 2.26.2