Re: [PATCH 0/7] Make gdbarch.sh shellcheck-clean

Simon Marchi
2020-04-30T00:34:23Z

On 2020-04-29 5:08 p.m., Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Simon> I ran shellcheck on gdbarch.sh and addressed all the warnings. It
> Simon> didn't catch anything serious, but I think it's good to have it clean
> Simon> anyway, so we can catch potential problems in future changes we do to
> Simon> this file.
>
> These all seemed fine to me.

Thanks, I'll push it.

> I'd like to see gdbarch.sh eventually go away entirely.
> Most of it could be ordinary C++ code. I don't have a concrete plan for
> this though. Mostly I've been reluctant to do it due to the amount of
> reindentation that will probably be involved, though I guess maybe I
> could write an emacs lisp script to handle this.

I think that gdbarch.sh will go away eventually too, but probably not soon,
so I thought it would still be worth it to do this work.

Even if you don't plan to do it, if you have ideas of how we could do the
equivalent in pure C++, it would be nice if you could spell them out somewhere.
I think about this some times, but I don't have a clear picture of how the
result could look like.

Simon