From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from barracuda.ebox.ca (barracuda.ebox.ca [96.127.255.19]) by sourceware.org (Postfix) with ESMTPS id C5F2C39858B3 for ; Tue, 28 Apr 2020 21:47:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C5F2C39858B3 X-ASG-Debug-ID: 1588110422-0c856e18f3114d090001-fS2M51 Received: from smtp.ebox.ca (smtp.ebox.ca [96.127.255.82]) by barracuda.ebox.ca with ESMTP id YhBHxvfF5LUJ0omp (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 28 Apr 2020 17:47:02 -0400 (EDT) X-Barracuda-Envelope-From: simon.marchi@efficios.com X-Barracuda-RBL-Trusted-Forwarder: 96.127.255.82 Received: from localhost.localdomain (unknown [192.222.164.54]) by smtp.ebox.ca (Postfix) with ESMTP id 413A4441D65; Tue, 28 Apr 2020 17:47:02 -0400 (EDT) From: Simon Marchi X-Barracuda-Effective-Source-IP: 192-222-164-54.qc.cable.ebox.net[192.222.164.54] X-Barracuda-Apparent-Source-IP: 192.222.164.54 X-Barracuda-RBL-IP: 192.222.164.54 To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 2/7] gdb: fix shellcheck warnings SC2086 (missing double quotes) in gdbarch.sh Date: Tue, 28 Apr 2020 17:46:50 -0400 X-ASG-Orig-Subj: [PATCH 2/7] gdb: fix shellcheck warnings SC2086 (missing double quotes) in gdbarch.sh Message-Id: <20200428214655.3255454-3-simon.marchi@efficios.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200428214655.3255454-1-simon.marchi@efficios.com> References: <20200428214655.3255454-1-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Barracuda-Connect: smtp.ebox.ca[96.127.255.82] X-Barracuda-Start-Time: 1588110422 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://96.127.255.19:443/cgi-mod/mark.cgi X-Barracuda-Scan-Msg-Size: 2689 X-Virus-Scanned: by bsmtpd at ebox.ca X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=8.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.81496 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Spam-Status: No, score=-41.7 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_SOFTFAIL, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Apr 2020 21:47:05 -0000 Fix all instances of: In gdbarch.sh line 31: if test ! -r ${file} ^-----^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: if test ! -r "${file}" Note that some instances of these are in text that is eval'ed. I'm pretty sure that things could go wrong during the eval too, but that's not something shellcheck can check. gdb/ChangeLog: * gdbarch.sh: Use double quotes around variables. --- gdb/gdbarch.sh | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/gdb/gdbarch.sh b/gdb/gdbarch.sh index 2780a819f915..a934a7aa6bc1 100755 --- a/gdb/gdbarch.sh +++ b/gdb/gdbarch.sh @@ -28,10 +28,10 @@ LC_ALL=C ; export LC_ALL compare_new () { file=$1 - if test ! -r ${file} + if test ! -r "${file}" then echo "${file} missing? cp new-${file} ${file}" 1>&2 - elif diff -u ${file} new-${file} + elif diff -u "${file}" "new-${file}" then echo "${file} unchanged" 1>&2 else @@ -70,7 +70,7 @@ ${line}" line="`echo "${line}" | sed -e 's/;;/; ;/g' -e 's/;;/; ;/g'`" OFS="${IFS}" ; IFS="[;]" - eval read ${read} <%s = %s;\n" "$function" "$function" printf "}\n" @@ -2192,7 +2192,7 @@ do printf "\n" printf "void\n" printf "set_gdbarch_%s (struct gdbarch *gdbarch,\n" "$function" - printf " `echo ${function} | sed -e 's/./ /g'` %s %s)\n" "$returntype" "$function" + printf " `echo "$function" | sed -e 's/./ /g'` %s %s)\n" "$returntype" "$function" printf "{\n" printf " gdbarch->%s = %s;\n" "$function" "$function" printf "}\n" -- 2.26.2