From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by sourceware.org (Postfix) with ESMTPS id 3F6EA386EC42 for ; Fri, 24 Apr 2020 13:37:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3F6EA386EC42 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wr1-x441.google.com with SMTP id j2so10847224wrs.9 for ; Fri, 24 Apr 2020 06:37:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RhwwkCFMQJRc9Y4A9Dn0KnieyvbZPjwyedcaE2FaYNk=; b=InJ0XquoLZufrMURkocun2k1eyxmJWs4GfKjAv0M5YNhuSBSguq6giyiGfDK63wr5V TXrOeaqfUoDVgBeW0NpDp0aQPRGdLiZsCE9Rnh+pYOPhh1dOSWfEe2jaV6VwTf6pPAY/ +NmG2Nk4re4tILZ5YRMYLtbXQhhaaNGxHf6v3hYLvHuYfi9Odew+z1OcGBRSgwzyawg0 ZaGOC3tNSULyfr93QWeBaiw4RnvSf7zvAf2ZDMy8BHnz1LYjaUPC8RG3esZxKNbIwwzb ajS1RY25FoA7t29YMJ4+7HdAxZ8YY5r1Ig9/IGvbNbK+kbDI/1AgP+os4vEX2xRB2DDW hDig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RhwwkCFMQJRc9Y4A9Dn0KnieyvbZPjwyedcaE2FaYNk=; b=gstI+HzD8HnWaviLKIym1r2gu9A0UwL4svxJe7K14TLJOJ+EmUVtS+VpCmHz7Tzl0s S1pHsJILGAir2+UZHSPojqnI/XLuyM4C0MOI3zugXT74NjgSOHHH42vpLFPOQfJ5XKgP TAqvy/LybATzwaWjk3fDUVTT/4bPRQq/b3hiN6OCD3a35o6RUcwrdgZRTvzW9PVejbwh ZHVvPaJkgM0W4Qq/jRPUTx9cWrvi14027V9PD+9rmMKq0UKqPzJvOTZ/M7DVnkZruwS7 6v7w0ZWQ6EdO8qkn3OA1UA4L9sULEUB+3s5pmzuc7Od4gUH1vwme8Cjbl5mk/vjq+C5S lDLA== X-Gm-Message-State: AGi0PuY9fJzKQi8OROHERS1rg/rPfrparKXmXw4opqPbVcvnGxRQJ6wP J1ID9+pOMXVPhBvEsIkQKRX+dg== X-Google-Smtp-Source: APiQypK3/W912l145IsxPSGKq4C8PVHzO2wFR6UAkx2ffL7mAOHx9zkN08o7tukG7viE95MQE9+SnQ== X-Received: by 2002:a5d:6887:: with SMTP id h7mr11150908wru.365.1587735472403; Fri, 24 Apr 2020 06:37:52 -0700 (PDT) Received: from localhost (host81-151-181-184.range81-151.btcentralplus.com. [81.151.181.184]) by smtp.gmail.com with ESMTPSA id s8sm8394917wru.38.2020.04.24.06.37.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Apr 2020 06:37:51 -0700 (PDT) Date: Fri, 24 Apr 2020 14:37:50 +0100 From: Andrew Burgess To: Tom Tromey Cc: "Sharma, Alok Kumar" , "George, Jini Susan" , "Achra, Nitika" , "gdb-patches@sourceware.org" Subject: Re: [PATCH] gdb/fortran: Allow Flang MAIN_ in Fortran testing Message-ID: <20200424133750.GD3522@embecosm.com> References: <20200424101752.GB3522@embecosm.com> <87sggthwk2.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87sggthwk2.fsf@tromey.com> X-Operating-System: Linux/5.5.17-200.fc31.x86_64 (x86_64) X-Uptime: 14:35:25 up 3 days, 21:32, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Apr 2020 13:37:57 -0000 * Tom Tromey [2020-04-24 06:56:13 -0600]: > >>>>> "Andrew" == Andrew Burgess writes: > > Andrew> And my main thought is that what we should do is override runto_main > Andrew> in lib/fortran.exp, and then switch all of the test over to using that > Andrew> instead, this would be more consistent with how the C/C++ tests work > Andrew> then. > > Redefining procs is a bit dangerous because it can change the test > environment for subsequent tests, which may not be Fortran tests. I'm > not sure if that's what you were proposing but I figured I'd point it > out just in case. OK, that's a valid point. Maybe we should just make 'proc runto_main' smarter then? Add some logic to pick a suitable name for the main function per-language? Or maybe we should do 'proc fortran_runto_main' .... ? I'd just like something that's more inline with the existing 'runto_main' in style I think.. Thanks, Andrew