From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sonic309-25.consmr.mail.ir2.yahoo.com (sonic309-25.consmr.mail.ir2.yahoo.com [77.238.179.83]) by sourceware.org (Postfix) with ESMTPS id 9C5A83858D33 for ; Wed, 22 Apr 2020 17:20:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9C5A83858D33 X-YMail-OSG: 5TOL3CcVM1lwupkw2RdAhhecF65wxVJThZ79Ug1DS2yJUchNyn9mpQWSEvQtNoB Oij4_KFueyUFACiuOhiXvK63.PlTZssEbwdNRCH_hRZpy0nRaElfVHh5BmhdBXHDI6WyVzL3eWaj 8EFt6kYFuFDACAJHg4XuLk7J.Fe.CNnMWTbK_vrHFkKVpI9QHVBCWzyI7B2kUHs_hRipfjMU_bRs e6E3ckY0sa61zx4G.C7EOMqJkhbBeGEfxJZVpSQqv9EvV9pxagQU3AktwoWsBEXVWbaoGVwN6CS. STQUa60Z0kNOz7HTFsHCqJTa6ZU3JPPAkQs757j4DTKk8iTa5pp5AQvrXiRCmagaznKD8Vhy13oM JmeIHwvBS6qLdxd__Xm50xIrdXIDlFZmUr_GmnT0q3Xz8PdD8QUxXrpbAYnLHLvOkk_3T9r8niBc MLrMf_b_OLNNCWDseXtH2YyxKTOe3EtbwNm4NYuucNqwZJTzdpg0R4dBMo0VvEzL3pXKH1on3biA fvNoe_kMVaRhftAfAncSSQDNny9.Qdvb17c4pCEYJvFa8_4cGQzCKn5SbVJElxVWFilHeVSr8IJM w.GQ1fJLQxGtOA.LE0YZ0J5r8neD55aE87PynGwLYDqakhRLJMtg_8JAM6obgNIlMaADhaSUWJ6D jDjDy5FwCv_KPW_JZbXXdi4U3a0QS.xlbK_nsPvcQXMoNzsa4Z2jNE6GCsspymp2IyQGSGNwSFvO HGxC0QVnkxZs7V2yg6iwf5PMJ5W5I.Pz1W.AQE4cIQmG_WXZRA6XjNe5YQXCFmx1tg501rUYQg4u Yf7Iuk6z2RXovPDTJcfxAqc43OVG5yvSPsc40ewWj2hOv9uvJbY2JPpcefOISwpygrjzot8yl2dc P411hqvVBBixnxMhf_lYDr2NSE5QobXKRVutN7rGzkiUA7_UUi1fmUM9mWcH_n_1g5HbchjW9Wyk ZFo575hN3mKw_5iRT_zwhZhNrUB6YJlA95vn.0O_tntuo9DGYMJh9l0lb5NhC5.AHqEaNbH0pCsG pLo7F_Z_wmY3XIgtjryiHS0kG.10Fp9RJ3H5mlannlbXyg_lcqMtjogFTT_YntO.8t2qlVWcXM1_ s3JFm_Ur05r2TwgfGQpTHqzZ8JOBzoz2vi1SxINGtcpI5BnP8ZVil4F9kO_XGlYYDv3_Pc0y6vjA Y5mFq4TKjO3rlNR438uhqxFBRlY5IJE38RbISLVvTMxpGmqvN7VPGjBixIjE4OBWxAiudiJwwAd4 Dn7bUU_pFCiaPtiArmOztCwoa6TdNK2V8MvvSE9_grW.cRc7YCV4o4na9eOIy63HrOWJAbZeeoWx b8S3h4Jsx_751ny1LUi1399M5POQW04LmsUN6s8TZhfe8Wi9Ef4G29AXOLdWD5tkvepRvKQIrvXR FwV5PpGfRDbAkhtf90Rpmlega Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.ir2.yahoo.com with HTTP; Wed, 22 Apr 2020 17:20:17 +0000 Received: by smtp425.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 1fc4cee3b2726a5cb07a1d49a0c358ea; Wed, 22 Apr 2020 17:20:16 +0000 (UTC) From: Hannes Domani To: gdb-patches@sourceware.org Subject: [PATCH] Fix search of large memory area in gdbserver Date: Wed, 22 Apr 2020 19:19:55 +0200 Message-Id: <20200422171955.600-1-ssbssa@yahoo.de> X-Mailer: git-send-email 2.26.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Antivirus: Avast (VPS 200421-2, 04/21/2020), Outbound message X-Antivirus-Status: Clean References: <20200422171955.600-1-ssbssa.ref@yahoo.de> X-Spam-Status: No, score=-16.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Apr 2020 17:20:21 -0000 If the search area is bigger than SEARCH_CHUNK_SIZE (16000), then you get an error in gdbserver: gdb: (gdb) find /w 0x3c43f0,+20000,0x04030201 gdb: Pattern not found. gdbserver: Unable to access 3997 bytes of target memory at 0x3c8273, halting search. The return value of any additional gdb_read_memory calls were compared with the wrong value, this fixes it. gdbserver/ChangeLog: 2020-04-22 Hannes Domani * server.cc (handle_search_memory_1): Fix gdb_read_memory return value comparison. --- gdbserver/server.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdbserver/server.cc b/gdbserver/server.cc index 77175ff74c..0672f9bc4d 100644 --- a/gdbserver/server.cc +++ b/gdbserver/server.cc @@ -1103,7 +1103,7 @@ handle_search_memory_1 (CORE_ADDR start_addr, CORE_ADDR search_space_len, : chunk_size); if (gdb_read_memory (read_addr, search_buf + keep_len, - nr_to_read) != search_buf_size) + nr_to_read) != nr_to_read) { warning ("Unable to access %ld bytes of target memory " "at 0x%lx, halting search.", -- 2.26.1