From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from barracuda.ebox.ca (barracuda.ebox.ca [96.127.255.19]) by sourceware.org (Postfix) with ESMTPS id C3F72385B835 for ; Thu, 16 Apr 2020 18:47:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C3F72385B835 X-ASG-Debug-ID: 1587062864-0c856e18f31007d60001-fS2M51 Received: from smtp.ebox.ca (smtp.ebox.ca [96.127.255.82]) by barracuda.ebox.ca with ESMTP id ho4lC78OE5ydaYbO (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 16 Apr 2020 14:47:44 -0400 (EDT) X-Barracuda-Envelope-From: simon.marchi@polymtl.ca X-Barracuda-RBL-Trusted-Forwarder: 96.127.255.82 Received: from localhost.localdomain (unknown [192.222.164.54]) by smtp.ebox.ca (Postfix) with ESMTP id CB417441D66; Thu, 16 Apr 2020 14:47:44 -0400 (EDT) From: Simon Marchi X-Barracuda-Effective-Source-IP: 192-222-164-54.qc.cable.ebox.net[192.222.164.54] X-Barracuda-Apparent-Source-IP: 192.222.164.54 X-Barracuda-RBL-IP: 192.222.164.54 To: gdb-patches@sourceware.org Subject: [PATCH v2 1/2] gdb: make is_linked_with_cygwin_dll handle import table not at beginning of .idata section Date: Thu, 16 Apr 2020 14:47:38 -0400 X-ASG-Orig-Subj: [PATCH v2 1/2] gdb: make is_linked_with_cygwin_dll handle import table not at beginning of .idata section Message-Id: <20200416184739.205859-1-simon.marchi@polymtl.ca> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200416154508.168585-1-simon.marchi@polymtl.ca> References: <20200416154508.168585-1-simon.marchi@polymtl.ca> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Barracuda-Connect: smtp.ebox.ca[96.127.255.82] X-Barracuda-Start-Time: 1587062864 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://96.127.255.19:443/cgi-mod/mark.cgi X-Barracuda-Scan-Msg-Size: 5120 X-Virus-Scanned: by bsmtpd at ebox.ca X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=8.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.81219 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Spam-Status: No, score=-39.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_DMARC_QUARANTINE, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_SOFTFAIL, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Apr 2020 18:47:47 -0000 When loading the file C:\Windows\SysWOW64\msvcrt.dll, taken from a Windows 10 system, into GDB, we get the following warning: warning: Failed to parse .idata section: name's virtual address (0x0) is outside .idata section's range [0xb82b8, 0xb97f0[. This uncovers an issue with how we parse the import table, part of the .idata section. Right now, we assume that the import table is located at the beginning of the section. That was the case in everything I had tried so far, but this file is an example where that's not true. We need to compute the offset of the import table within the .idata section, and start there, instead of at the beginning of the .idata section. Using the file mentioned above, this is the values we have to work with: A) bfd_section_vma (idata_section) 101b8000 B) Import table's virtual address b82b8 C) Image base 10100000 The virtual address that BFD returns us for the section has the image base applied, so we need to subtract it first. The offset of the table in the section is therefore: B - (A - C) This patch implements that. gdb/ChangeLog: windows-tdep.c (is_linked_with_cygwin_dll): Consider case where import table is not at beginning of .idata section. --- New in v2: - Display warning and return false if the import table address does not fall within the .idata section range. --- gdb/windows-tdep.c | 47 +++++++++++++++++++++++++++++++++------------- 1 file changed, 34 insertions(+), 13 deletions(-) diff --git a/gdb/windows-tdep.c b/gdb/windows-tdep.c index d1894ca08884..50bb9591f931 100644 --- a/gdb/windows-tdep.c +++ b/gdb/windows-tdep.c @@ -999,11 +999,32 @@ is_linked_with_cygwin_dll (bfd *abfd) if (idata_section == nullptr) return false; - /* Find the virtual address of the .idata section. We must subtract this - from the RVAs (relative virtual addresses) to obtain an offset in the - section. */ - bfd_vma idata_addr - = pe_data (abfd)->pe_opthdr.DataDirectory[PE_IMPORT_TABLE].VirtualAddress; + bfd_size_type idata_section_size = bfd_section_size (idata_section); + internal_extra_pe_aouthdr *pe_extra = &pe_data (abfd)->pe_opthdr; + bfd_vma import_table_va = pe_extra->DataDirectory[PE_IMPORT_TABLE].VirtualAddress; + bfd_vma idata_section_va = bfd_section_vma (idata_section); + + /* The section's virtual address as reported by BFD has the image base applied, + remove it. */ + gdb_assert (idata_section_va >= pe_extra->ImageBase); + idata_section_va -= pe_extra->ImageBase; + + bfd_vma idata_section_end_va = idata_section_va + idata_section_size; + + /* Make sure that the import table is indeed within the .idata section's range. */ + if (import_table_va < idata_section_va + || import_table_va >= idata_section_end_va) + { + warning (_("\ +%s: import table's virtual address (0x%" BFD_VMA_FMT "x) is outside .idata \ +section's range [0x%" BFD_VMA_FMT "x, 0x%" BFD_VMA_FMT "x[."), + bfd_get_filename (abfd), import_table_va, idata_section_va, + idata_section_end_va); + return false; + } + + /* The import table starts at this offset into the .idata section. */ + bfd_vma import_table_offset_in_sect = import_table_va - idata_section_va; /* Get the section's data. */ gdb::byte_vector idata_contents; @@ -1013,9 +1034,10 @@ is_linked_with_cygwin_dll (bfd *abfd) return false; } - size_t idata_size = idata_contents.size (); - const gdb_byte *iter = idata_contents.data (); - const gdb_byte *end = idata_contents.data () + idata_size; + gdb_assert (idata_contents.size () == idata_section_size); + + const gdb_byte *iter = idata_contents.data () + import_table_offset_in_sect; + const gdb_byte *end = idata_contents.data () + idata_section_size; const pe_import_directory_entry null_dir_entry = { 0 }; /* Iterate through all directory entries. */ @@ -1036,21 +1058,20 @@ is_linked_with_cygwin_dll (bfd *abfd) sizeof (pe_import_directory_entry)) == 0) break; - bfd_vma name_addr = dir_entry->name_rva; + bfd_vma name_va = dir_entry->name_rva; /* If the name's virtual address is smaller than the section's virtual address, there's a problem. */ - if (name_addr < idata_addr - || name_addr >= (idata_addr + idata_size)) + if (name_va < idata_section_va || name_va >= idata_section_end_va) { warning (_("\ Failed to parse .idata section: name's virtual address (0x%" BFD_VMA_FMT "x) \ is outside .idata section's range [0x%" BFD_VMA_FMT "x, 0x%" BFD_VMA_FMT "x[."), - name_addr, idata_addr, idata_addr + idata_size); + name_va, idata_section_va, idata_section_end_va); break; } - const gdb_byte *name = &idata_contents[name_addr - idata_addr]; + const gdb_byte *name = &idata_contents[name_va - idata_section_va]; /* Make sure we don't overshoot the end of the section with the streq. */ if (name + sizeof (CYGWIN_DLL_NAME) > end) -- 2.26.0