From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rock.gnat.com (rock.gnat.com [IPv6:2620:20:4000:0:a9e:1ff:fe9b:1d1]) by sourceware.org (Postfix) with ESMTP id 079253877034 for ; Mon, 13 Apr 2020 13:11:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 079253877034 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=brobecker@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id A9DD5117716; Mon, 13 Apr 2020 09:11:07 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id pdIinMI79dNs; Mon, 13 Apr 2020 09:11:07 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 524891174FC; Mon, 13 Apr 2020 09:11:07 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 0679F83399; Mon, 13 Apr 2020 06:11:05 -0700 (PDT) Date: Mon, 13 Apr 2020 06:11:04 -0700 From: Joel Brobecker To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH][gdb/testsuite] Fix gdb.ada/catch_ex_std.exp gnatlink FAIL Message-ID: <20200413131104.GA5763@adacore.com> References: <20200410150913.GA30640@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200410150913.GA30640@delia> User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-17.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Apr 2020 13:11:09 -0000 Hi Tom, > 2020-04-10 Tom de Vries > > * lib/ada.exp (find_ada_tool): Pass --GCC and -B to gnatlink, similar > to what find_gnatmake does. Thanks for the patch. It does look good to me, so go ahead and apply. > --- > gdb/testsuite/lib/ada.exp | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/gdb/testsuite/lib/ada.exp b/gdb/testsuite/lib/ada.exp > index 6648566ec3..0ffc5957c8 100644 > --- a/gdb/testsuite/lib/ada.exp > +++ b/gdb/testsuite/lib/ada.exp > @@ -133,6 +133,9 @@ proc find_ada_tool {tool} { > > if {![is_remote host]} { > set result [lookfor_file $root $tool] > + if { $result != "" && $tool == "gnatlink" } { > + set result "$result --GCC=$root/xgcc -B$root" > + } > } > > if {$result == ""} { -- Joel