From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rock.gnat.com (rock.gnat.com [205.232.38.15]) by sourceware.org (Postfix) with ESMTP id 38377385B835 for ; Fri, 10 Apr 2020 00:10:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 38377385B835 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=brobecker@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 11AAC11672C; Thu, 9 Apr 2020 20:10:48 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id LuKIrVCj29Tt; Thu, 9 Apr 2020 20:10:48 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id D6915116540; Thu, 9 Apr 2020 20:10:47 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 4376D83399; Thu, 9 Apr 2020 17:10:46 -0700 (PDT) Date: Thu, 9 Apr 2020 17:10:46 -0700 From: Joel Brobecker To: Andrew Burgess Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] Add git sha information to the gdb version string Message-ID: <20200410001046.GK9860@adacore.com> References: <47128465-bbae-6241-6b04-929163f15229@simark.ca> <16599d81be47851f9ce53d7da037d9a1cdeba490.1585311874.git.andrew.burgess@embecosm.com> <20200410000158.GJ9860@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200410000158.GJ9860@adacore.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Apr 2020 00:10:49 -0000 > What do you guys think of adding a configure option to pass a "git-tag", > for instance, which, when passed, would use that instead of trying > to calculate it on the fly? Other ideas (brainstorming): Look for a file in the source which, if present, would either: - Be executed as a script; or - Just contain the ID we want to add. These might be easier to implement, and could also integrate well the creation of source packages that don't have the .git metadata... -- Joel