From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 249B1385B835 for ; Mon, 30 Mar 2020 08:53:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 249B1385B835 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 2B597AFB8; Mon, 30 Mar 2020 08:53:54 +0000 (UTC) Date: Mon, 30 Mar 2020 10:53:52 +0200 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [committed][gdb/testsuite] Fix c-linkage-name.exp with {cc-with-gdb-index,readnow}.exp Message-ID: <20200330085351.GA19384@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-33.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Mar 2020 08:53:56 -0000 Hi, When running test-case gdb.base/c-linkage-name.exp with target board cc-with-gdb-index.exp, I see: ... FAIL: gdb.base/c-linkage-name.exp: maint info psymtab: c-linkage-name-2.c: no FAIL: gdb.base/c-linkage-name.exp: maint info psymtab: c-linkage-name-2.c: yes ... The FAILs are due to the fact that partial symbol tables are not generated for indexed executables. When running the same test-case with target board readnow.exp, I see: ... FAIL: gdb.base/c-linkage-name.exp: maint info psymtab: c-linkage-name-2.c: no FAIL: gdb.base/c-linkage-name.exp: print symada__cS before partial symtab \ expansion FAIL: gdb.base/c-linkage-name.exp: maint info psymtab: c-linkage-name-2.c: yes ... The "maint info psymtab" FAILs are also due to fact that the partial symbol tables not generated, but in this case it's because the symtabs are fully expanded upon load due to using -readnow. The "print symada__cS before partial symtab expansion" test intends to test the state before symbol table expansion, and with -readnow that's not possible. Mark these FAILs as UNSUPPORTED. Tested on x86_64-linux, with native, and target boards cc-with-gdb-index.exp, cc-with-debug-names.exp and readnow.exp. Committed to trunk. Thanks, - Tom [gdb/testsuite] Fix c-linkage-name.exp with {cc-with-gdb-index,readnow}.exp gdb/testsuite/ChangeLog: 2020-03-30 Tom de Vries * gdb.base/c-linkage-name.exp: Use readnow call to mark a test unsupported. (verify_psymtab_expanded): Move ... * lib/gdb.exp (verify_psymtab_expanded): ... here. Add unsupported test. (readnow): New proc. --- gdb/testsuite/gdb.base/c-linkage-name.exp | 27 ++++++++-------------- gdb/testsuite/lib/gdb.exp | 38 +++++++++++++++++++++++++++++++ 2 files changed, 48 insertions(+), 17 deletions(-) diff --git a/gdb/testsuite/gdb.base/c-linkage-name.exp b/gdb/testsuite/gdb.base/c-linkage-name.exp index 4551c8dcac..9a472a79a2 100644 --- a/gdb/testsuite/gdb.base/c-linkage-name.exp +++ b/gdb/testsuite/gdb.base/c-linkage-name.exp @@ -26,30 +26,23 @@ if { [gdb_compile "${sources}" "${binfile}" executable {debug}] != "" } { } clean_restart ${binfile} - -# Verify that partial symtab expansion for $filename has state $readin - -proc verify_psymtab_expanded { filename readin } { - set cmd "maint info psymtab" - set test "$cmd: $filename: $readin" - set re [multi_line \ - " \{ psymtab \[^\r\n\]*$filename\[^\r\n\]*" \ - " readin $readin" \ - ".*"] - - gdb_test $cmd $re $test -} +set readnow [readnow] # Verify that partial symtab expansion has not taken place for # c-linkage-name-2.c. verify_psymtab_expanded c-linkage-name-2.c no -# Try to print MUNDANE, but using its linkage name. +set test "print symada__cS before partial symtab expansion" +if { $readnow } { + unsupported $test +} else { + # Try to print MUNDANE, but using its linkage name. -gdb_test "print symada__cS" \ - "'symada__cS' has unknown type; cast it to its declared type" \ - "print symada__cS before partial symtab expansion" + gdb_test "print symada__cS" \ + "'symada__cS' has unknown type; cast it to its declared type" \ + $test +} # Force the symbols to be expanded for the unit that contains # our symada__cS symbol by, e.g. inserting a breakpoint on one diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index e17ac0ef75..3bd08816b6 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -6982,5 +6982,43 @@ gdb_caching_proc supports_statement_frontiers { } executable "additional_flags=-gstatement-frontiers"] } +# Return 1 if symbols were read in using -readnow. Otherwise, return 0. + +proc readnow { } { + set cmd "maint print objfiles" + gdb_test_multiple $cmd "" { + -re -wrap "\r\n.gdb_index: faked for \"readnow\"\r\n.*" { + return 1 + } + -re -wrap "" { + return 0 + } + } + + return 0 +} + +# Verify that partial symtab expansion for $filename has state $readin. + +proc verify_psymtab_expanded { filename readin } { + global gdb_prompt + + set cmd "maint info psymtab" + set test "$cmd: $filename: $readin" + set re [multi_line \ + " \{ psymtab \[^\r\n\]*$filename\[^\r\n\]*" \ + " readin $readin" \ + ".*"] + + gdb_test_multiple $cmd $test { + -re "$cmd\r\n$gdb_prompt $" { + unsupported $gdb_test_name + } + -re -wrap $re { + pass $gdb_test_name + } + } +} + # Always load compatibility stuff. load_lib future.exp