From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway24.websitewelcome.com (gateway24.websitewelcome.com [192.185.51.196]) by sourceware.org (Postfix) with ESMTPS id C90A1385E013 for ; Sat, 28 Mar 2020 19:22:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C90A1385E013 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 522983E25 for ; Sat, 28 Mar 2020 14:22:10 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id IH22joCLq8vkBIH22jdfeD; Sat, 28 Mar 2020 14:22:10 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc:MIME-Version :Content-Type:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=8A/eIUK5goRFFLvnHwOaWddWuVfnj4DtaBccZ0Ld5r8=; b=UHgnnDdacI6zTJDptPUlK0OA7U YGaFvviPw1/SFoJlmRghqjX7ixBF3CST0NKgtcpFMjE4OCsUEsiDbsijHxZIUDYXnPIySykZ6DVcJ eGeCZfuT8a7ieX/atO3DHM9la; Received: from 97-118-117-21.hlrn.qwest.net ([97.118.117.21]:55190 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jIH22-003oZR-3Y for gdb-patches@sourceware.org; Sat, 28 Mar 2020 13:22:10 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Subject: [PATCH 00/20] Make DWARF attribute references safe Date: Sat, 28 Mar 2020 13:21:48 -0600 Message-Id: <20200328192208.11324-1-tom@tromey.com> X-Mailer: git-send-email 2.17.2 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.117.21 X-Source-L: No X-Exim-ID: 1jIH22-003oZR-3Y X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-117-21.hlrn.qwest.net (bapiya.Home) [97.118.117.21]:55190 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_DNSWL_NONE, RCVD_IN_SBL_CSS, SPF_HELO_PASS, SPF_NEUTRAL, TXREP, URIBL_CSS, URIBL_CSS_A autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Mar 2020 19:22:12 -0000 This series changes the DWARF code to always check that the use of an attribute's value is safe -- that is, that the requested type corresponds to one of the forms that can construct a value of that type. This caught some minor bugs in the DWARF reader, though, IMO, nothing very serious. Attribute typing is still somewhat ad hoc. That is, while the DWARF standard specifies the type classes of forms, gdb largely doesn't conform to this. Instead, it is more lenient. This could be changed, but I didn't want to mix things too much in this series. Also there's an argument to be made that there's nothing wrong with the current approach. Regression tested by the buildbot. Let me know what you think. Tom