From: Kamil Rytarowski <n54@gmx.com>
To: gdb-patches@sourceware.org
Subject: [PATCH] Add support for NetBSD threads in sparc-nat.c
Date: Sat, 14 Mar 2020 19:27:10 +0100 [thread overview]
Message-ID: <20200314182710.11396-1-n54@gmx.com> (raw)
NetBSD ptrace(2) accepts thread id (LWP) as the 4th argument for threads.
This file is still shared with other targets that use different 4th argument
type.
---
gdb/sparc-nat.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/gdb/sparc-nat.c b/gdb/sparc-nat.c
index dff0f521565..1e890bd8613 100644
--- a/gdb/sparc-nat.c
+++ b/gdb/sparc-nat.c
@@ -154,6 +154,12 @@ sparc_fetch_inferior_registers (struct regcache *regcache, int regnum)
registers can be written. */
pid = get_ptrace_pid (regcache->ptid ());
+#ifdef __NetBSD__
+# define lwp regcache->ptid ().lwp ()
+#else
+# define lwp (PTRACE_TYPE_ARG4) 0
+#endif
+
if (regnum == SPARC_G0_REGNUM)
{
gdb_byte zero[8] = { 0 };
@@ -166,7 +172,7 @@ sparc_fetch_inferior_registers (struct regcache *regcache, int regnum)
{
gregset_t regs;
- if (ptrace (PTRACE_GETREGS, pid, (PTRACE_TYPE_ARG3) ®s, 0) == -1)
+ if (ptrace (PTRACE_GETREGS, pid, (PTRACE_TYPE_ARG3) ®s, lwp) == -1)
perror_with_name (_("Couldn't get registers"));
sparc_supply_gregset (sparc_gregmap, regcache, -1, ®s);
@@ -178,11 +184,13 @@ sparc_fetch_inferior_registers (struct regcache *regcache, int regnum)
{
fpregset_t fpregs;
- if (ptrace (PTRACE_GETFPREGS, pid, (PTRACE_TYPE_ARG3) &fpregs, 0) == -1)
+ if (ptrace (PTRACE_GETFPREGS, pid, (PTRACE_TYPE_ARG3) &fpregs, lwp) == -1)
perror_with_name (_("Couldn't get floating point status"));
sparc_supply_fpregset (sparc_fpregmap, regcache, -1, &fpregs);
}
+
+#undef lwp
}
void
@@ -195,6 +203,12 @@ sparc_store_inferior_registers (struct regcache *regcache, int regnum)
about threaded assumptions. */
pid = get_ptrace_pid (regcache->ptid ());
+#ifdef __NetBSD__
+# define lwp regcache->ptid ().lwp ()
+#else
+# define lwp (PTRACE_TYPE_ARG4) 0
+#endif
+
if (regnum == -1 || sparc_gregset_supplies_p (gdbarch, regnum))
{
gregset_t regs;
@@ -245,6 +259,7 @@ sparc_store_inferior_registers (struct regcache *regcache, int regnum)
if (regnum != -1)
return;
}
+#undef lwp
}
\f
--
2.25.0
next reply other threads:[~2020-03-14 18:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-14 18:27 Kamil Rytarowski [this message]
2020-03-16 21:35 ` Christian Biesinger
2020-03-17 9:38 ` Kamil Rytarowski
2020-03-17 9:40 Kamil Rytarowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200314182710.11396-1-n54@gmx.com \
--to=n54@gmx.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox