Re: [PATCH v3 00/29] Windows code sharing + bug fix

Jon Turney
2020-04-09T14:57:32Z

On 09/04/2020 03:49, Tom Tromey wrote:
>>>>>> "Hannes" == Hannes Domani via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Hannes> I seems I kinda missed to actually use Wow64SuspendThread when I implemented
> Hannes> the WOW64 stuff.
>
> Could you double-check to make sure I didn't mess it up when rebasing
> this series over your patches?
>
> Hannes> Maybe I should just try to implement the WOW64 stuff for gdbserver as well, and
> Hannes> then try to move more shared stuff into nat/windows-nat.c?
>
> It would be nice to try to keep the code more in sync.
> They still aren't identical but they do share quite a bit more now.
> So, unless it's unusually hard, I would say yes.

I wonder if SuspendThread() is actually needed at all, since it doesn't
make a huge amount of sense for the debugee to still be running when
WaitForDebugEvent() returns.