From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 0C4D9394441B for ; Thu, 12 Mar 2020 10:59:01 +0000 (GMT) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 1F855AE3A for ; Thu, 12 Mar 2020 10:59:00 +0000 (UTC) Date: Thu, 12 Mar 2020 11:58:58 +0100 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [committed][gdb/testsuite] Fix dw2-ranges-base.exp FAIL with lib debuginfo Message-ID: <20200312105856.GA16425@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Mar 2020 10:59:01 -0000 Hi, When running test-case gdb.dwarf2/dw2-ranges-base.exp with debuginfo for various libs installed, I run into: ... (gdb) maint info line-table^M ... objfile: /usr/lib/debug/lib64/ld-2.26.so-2.26-lp151.18.7.x86_64.debug \ ((struct objfile *) 0x1a9d7f0)^M compunit_symtab: ((struct compunit_symtab *) 0x2061090)^M symtab: /usr/src/debug/glibc-2.26-lp151.18.7.x86_64/sysdeps/generic/\ dl-fcntl.h ((struct symtab *) 0x2182660)^M linetable: ((struct linetable *) 0x0):^M No line table.^M (gdb) FAIL: gdb.dwarf2/dw2-ranges-base.exp: count END markers in line table ... The test-case intends to count 3 END markers in the line table for gdb.dwarf2/dw2-ranges-base.c: ... symtab: /data/gdb_versions/devel/binutils-gdb.git/gdb/testsuite/gdb.dwarf2/\ dw2-ranges-base.c ((struct symtab *) 0x2a7e8c0)^M linetable: ((struct linetable *) 0x2a7ea60):^M INDEX LINE ADDRESS IS-STMT^M 0 31 0x00000000004004a7 Y^M 1 21 0x00000000004004ae Y^M 2 END 0x00000000004004ae Y^M 3 11 0x00000000004004ba Y^M 4 END 0x00000000004004ba Y^M 5 END 0x00000000004004c6 Y^M ... but ends up counting 70+ END markers for all line tables. Fix this by limiting the line tables emitted by the maint info line-table command. Tested on x86_64-linux. Committed to trunk. Thanks, - Tom [gdb/testsuite] Fix dw2-ranges-base.exp FAIL with lib debuginfo gdb/testsuite/ChangeLog: 2020-03-12 Tom de Vries * gdb.dwarf2/dw2-ranges-base.exp: Limit "maint info line-table" to gdb.dwarf2/dw2-ranges-base.c. --- gdb/testsuite/gdb.dwarf2/dw2-ranges-base.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.dwarf2/dw2-ranges-base.exp b/gdb/testsuite/gdb.dwarf2/dw2-ranges-base.exp index 7f7301502a..c1a3ab155f 100644 --- a/gdb/testsuite/gdb.dwarf2/dw2-ranges-base.exp +++ b/gdb/testsuite/gdb.dwarf2/dw2-ranges-base.exp @@ -144,7 +144,7 @@ gdb_test "info line frame3" \ # Ensure that the line table correctly tracks the end of sequence markers. set end_seq_count 0 -gdb_test_multiple "maint info line-table" \ +gdb_test_multiple "maint info line-table gdb.dwarf2/dw2-ranges-base.c" \ "count END markers in line table" { -re "^$decimal\[ \t\]+$decimal\[ \t\]+$hex\(\[ \t\]+Y\)?\r\n" { exp_continue