From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by sourceware.org (Postfix) with ESMTPS id 833AC395ACFF for ; Tue, 10 Mar 2020 23:01:35 +0000 (GMT) Received: by mail-wm1-x344.google.com with SMTP id r7so1847252wmg.0 for ; Tue, 10 Mar 2020 16:01:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=HxSlX8kvRW3c2RZZb3i084Y4c4wSrwkbH8aj0JGO3C0=; b=ghdaEvGyc7X0nfUp1k5G16ZV0hJ7HEyTgun2NNFRXmvfg56gqfrU5aHarIL/zhxH1X 9uHYoxSXNLXDVgavXQqahzkjOd7ypF/fzxYd5uawSnTL7Pvon6FB2qzjIOdMx/QSrKoC M8oiKJb3lXgQjO+HaUIDVOWBUaew7r1dTKHF/Xir3yew2D1vFH9+F2wXKTNSpzT2qZ4+ bwiCHeIn7Civeki8njGu/FcSZOLDrVsbZaNPdKpxPLwmFE4y6+RWzHccMxJ11Lv3LMsF PO521niD/l4nqdIppOsSEpmgqk5c7rvrwMk66ma0jO8A8xCNheBJiqeut+xDRprcFTg5 9MWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=HxSlX8kvRW3c2RZZb3i084Y4c4wSrwkbH8aj0JGO3C0=; b=eV/uan2TTfWnDtA1jL7EwR9ldUHvlZ3x8Fvzfc5Io82IYjqd9ZFWbqklJm6dKwDjT2 BXhzW8JhCpFLEf1+T6wu9cjfc9bN3hbv81SPk8RQNynzZYp+nMEB7SonnTl/5muNuFJ3 vexpqXTizmiuVSQfKLa7y/BvwWWUt8ECtUIPnPM0S3EluItpOrLGDxCsO4gWt8pK3D5I lhulLY9ElEcT6J+58pFbhc6+DCoOEdsIEWQ4irjXdGnF1auhkKHOqtZs0quYwCaFF1Yr OB/DFYXmY9N7DqIHRHydBv4xoCQhIU03txiPpeN4IQ+mV+YSJgW2RW16o77f9tqF3h/D B6QA== X-Gm-Message-State: ANhLgQ3DI8w+JLTkMsBB9garj0dGLqHuArExiVm2sm1N8TwF16nEDM8g Zqyr2W0A/mN7W8heL0L35StCkw== X-Google-Smtp-Source: ADFU+vuklmA+6gCyGrXvs2sS/BABpyzlw1tzju5Epzmdcze6VnrPAebuPettdr7+3M576OfqHrjCJw== X-Received: by 2002:a1c:2d86:: with SMTP id t128mr4480815wmt.38.1583881294560; Tue, 10 Mar 2020 16:01:34 -0700 (PDT) Received: from localhost (host86-180-62-221.range86-180.btcentralplus.com. [86.180.62.221]) by smtp.gmail.com with ESMTPSA id f187sm2484961wme.31.2020.03.10.16.01.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 10 Mar 2020 16:01:33 -0700 (PDT) Date: Tue, 10 Mar 2020 23:01:32 +0000 From: Andrew Burgess To: Bernd Edlinger Cc: "gdb-patches@sourceware.org" Subject: Re: [PATCHv2 0/2] Line table is_stmt support Message-ID: <20200310230132.GF3317@embecosm.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux/4.18.19-100.fc27.x86_64 (x86_64) X-Uptime: 23:00:35 up 25 days, 10:29, X-Fortune: The cables are not the same length. X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Mar 2020 23:01:36 -0000 * Bernd Edlinger [2020-03-08 14:39:44 +0000]: > On 3/8/20 1:50 PM, Andrew Burgess wrote: > > Patch #1 is unchanged. > > > > Patch #2 includes additional changes in infrun.c based on Bernd's > > suggested fix, as well as his additional tests. > > > > Bernd, > > > > If you are happy with this version of the patch that I'll merge this > > in the next few days. > > > > Sure, a quick smoke test shows this is still on the right track. > > I will post a re-based version of my follow-up patch in a moment. I have now pushed this series to master. I will review your follow up patch in more detail tomorrow. Thanks, Andrew > > > Thanks > Bernd. > > > Thanks, > > Andrew > > > > -- > > > > Andrew Burgess (2): > > gdb/testsuite: Add is-stmt support to the DWARF compiler > > gdb: Add support for tracking the DWARF line table is-stmt field > > > > gdb/ChangeLog | 38 ++++ > > gdb/buildsym-legacy.c | 4 +- > > gdb/buildsym.c | 14 +- > > gdb/buildsym.h | 3 +- > > gdb/disasm.c | 6 + > > gdb/dwarf2/read.c | 13 +- > > gdb/infrun.c | 51 +++-- > > gdb/jit.c | 1 + > > gdb/record-btrace.c | 11 +- > > gdb/stack.c | 2 +- > > gdb/symmisc.c | 10 +- > > gdb/symtab.c | 25 ++- > > gdb/symtab.h | 10 + > > gdb/testsuite/ChangeLog | 16 ++ > > gdb/testsuite/gdb.cp/step-and-next-inline.cc | 66 +++++++ > > gdb/testsuite/gdb.cp/step-and-next-inline.exp | 119 ++++++++++++ > > gdb/testsuite/gdb.cp/step-and-next-inline.h | 38 ++++ > > gdb/testsuite/gdb.dwarf2/dw2-is-stmt-2.c | 99 ++++++++++ > > gdb/testsuite/gdb.dwarf2/dw2-is-stmt-2.exp | 265 +++++++++++++++++++++++++ > > gdb/testsuite/gdb.dwarf2/dw2-is-stmt.c | 61 ++++++ > > gdb/testsuite/gdb.dwarf2/dw2-is-stmt.exp | 267 ++++++++++++++++++++++++++ > > gdb/testsuite/gdb.dwarf2/dw2-ranges-base.exp | 6 +- > > gdb/testsuite/lib/dwarf.exp | 8 +- > > gdb/xcoffread.c | 4 + > > 24 files changed, 1107 insertions(+), 30 deletions(-) > > create mode 100644 gdb/testsuite/gdb.cp/step-and-next-inline.cc > > create mode 100644 gdb/testsuite/gdb.cp/step-and-next-inline.exp > > create mode 100644 gdb/testsuite/gdb.cp/step-and-next-inline.h > > create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-is-stmt-2.c > > create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-is-stmt-2.exp > > create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-is-stmt.c > > create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-is-stmt.exp > >