From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73643 invoked by alias); 6 Mar 2020 11:02:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 73635 invoked by uid 89); 6 Mar 2020 11:02:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-12.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=struggling X-HELO: mail-wm1-f43.google.com Received: from mail-wm1-f43.google.com (HELO mail-wm1-f43.google.com) (209.85.128.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Mar 2020 11:02:15 +0000 Received: by mail-wm1-f43.google.com with SMTP id x3so4002253wmj.1 for ; Fri, 06 Mar 2020 03:02:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=aXTEc8z3zU6WKzNPo1umQu96ANGrmvyyjRF30ojYvUE=; b=Pp7WACrWOfs+pZrkMhsG5+votYV95TrFMYNvXYgmBbQ3+xBk1rhgjECa7aLAJ1gtx3 JdOK84MGAptYzTdICBgY8Gp99/iCvWDX1+J42wrEvKJLre5HL1MemMsfpN5bpDYmysMe /03nxs/kXvdP8W1ooA1y8eSbnbfYsNMGrQEoksga0O27JIcGZ2PP/T5TQmXI2AvF9BTu utPPWPm8fTnh3slr7Wr/ZYonuHqOEGSFyrOI7gkmYVvWN13miyKjjjOaV0Pi0zAiSJ8k /5eWRKWVcAB5Xdh3yKBD6XjT7hyKso7QzjQuk0WyEm4O9dHE3vPbmbcApBKkxJwFfaVK Jw+A== Return-Path: Received: from localhost (host86-180-62-221.range86-180.btcentralplus.com. [86.180.62.221]) by smtp.gmail.com with ESMTPSA id v8sm14111941wma.28.2020.03.06.03.02.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 06 Mar 2020 03:02:12 -0800 (PST) Date: Fri, 06 Mar 2020 11:02:00 -0000 From: Andrew Burgess To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH][gdb] Remove trailing "done" after "Reading symbols from" message Message-ID: <20200306110211.GC3317@embecosm.com> References: <20200304132133.GA26507@delia> <20200304140757.GZ3317@embecosm.com> <99800816-3525-99a6-c287-b58215d93279@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <99800816-3525-99a6-c287-b58215d93279@suse.de> X-Fortune: I didn't know he was dead User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2020-03/txt/msg00139.txt * Tom de Vries [2020-03-04 15:13:08 +0100]: > On 04-03-2020 15:07, Andrew Burgess wrote: > > * Tom de Vries [2020-03-04 14:21:34 +0100]: > > > >> Hi, > >> > >> Using verbose, we get some detail on symbol loading: > >> ... > >> $ gdb a.out -iex "set verbose on" > >> Reading symbols from a.out... > >> Reading in symbols for /home/vries/hello.c...done. > >> (gdb) > >> ... > >> > >> And using debug symtab-create, much more detail: > >> ... > >> $ gdb a.out -iex "set verbose on" -iex "set debug symtab-create 1" > >> Reading symbols from a.out... > >> Reading minimal symbols of objfile /data/gdb_versions/devel/lto/a.out ... > >> Installing 30 minimal symbols of objfile /data/gdb_versions/devel/lto/a.out. > >> Done reading minimal symbols. > >> Creating one or more psymtabs for objfile /data/gdb_versions/devel/lto/a.out ... > >> Created psymtab 0x35a3de0 for module ../sysdeps/x86_64/start.S. > >> Created psymtab 0x353e4e0 for module init.c. > >> Created psymtab 0x353e560 for module ../sysdeps/x86_64/crti.S. > >> Created psymtab 0x353e5e0 for module /home/vries/hello.c. > >> Created psymtab 0x35bd530 for module elf-init.c. > >> Created psymtab 0x35bd5b0 for module ../sysdeps/x86_64/crtn.S. > >> Reading in symbols for /home/vries/hello.c...Created compunit symtab 0x354bd20 for hello.c. > >> done. > >> (gdb) > > > > I'm struggling to understand what problem you're trying to solve > > here. In general, if we switch on any of the 'set debug ...' flags > > the output from GDB gets confused. These flags aren't intended for > > general use, and trying to "fix" GDB's output in the face of these > > flags is going to be a huge task, for I'm not sure what benefit. > > > > Other than the output looking a little neater, is there an actual > > problem solved here? > > This patch is intended to make the output look a little neater. Oh, yeah, sorry, I miss-read the original patch description. I'm fine with this. Thanks, Andrew