From: Joel Brobecker <brobecker@adacore.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: Andrew Burgess <andrew.burgess@embecosm.com>,
GDB Patches <gdb-patches@sourceware.org>,
Philippe Waroquiers <philippe.waroquiers@skynet.be>,
Pedro Alves <palves@redhat.com>
Subject: Re: [PATCH] Fix printf of a convenience variable holding an inferior address
Date: Wed, 04 Mar 2020 10:53:00 -0000 [thread overview]
Message-ID: <20200304105330.GA4745@adacore.com> (raw)
In-Reply-To: <87wo81criy.fsf@redhat.com>
Hi Sergio,
> >>> gdb/ChangeLog:
> >>> 2020-03-02 Sergio Durigan Junior <sergiodj@redhat.com>
> >>>
> >>> * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
> >>> when verifying if dealing with a convenience variable.
> >>>
> >>> gdb/testsuite/ChangeLog:
> >>> 2020-03-02 Sergio Durigan Junior <sergiodj@redhat.com>
> >>>
> >>> * gdb.base/printcmds.exp: Add test to verify printf of a
> >>> variable holding an address.
> >>
> >> LGTM.
> >
> > Thanks, pushed:
> >
> > 7b973adce2b486518d3150db257b179e1b9a5d33
>
> BTW, this also affects 9.1 (in fact, that's where I found the bug). I
> can create a tracking bug and backport it to the branch if the issue and
> fix are deemed important enough.
Do you know if this issue is a regression, compared to previous
released versions?
In terms of putting it in 9.2, I think we could do it; the patch
does look safe to me.
--
Joel
next prev parent reply other threads:[~2020-03-04 10:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 21:16 [RFA] Ensure GDB printf command can print convenience var strings without a target Philippe Waroquiers
2019-06-11 2:29 ` Eli Zaretskii
2019-07-05 20:01 ` PING " Philippe Waroquiers
2019-07-08 18:13 ` Pedro Alves
2019-07-08 22:41 ` Philippe Waroquiers
2019-07-09 4:36 ` New FAIL on gdb.base/printcmds.exp (was: Re: [RFA] Ensure GDB printf command can print convenience var strings without a target.) Sergio Durigan Junior
2020-03-02 2:46 ` [PATCH] Fix printf of a convenience variable holding an inferior address Sergio Durigan Junior
2020-03-03 13:39 ` Andrew Burgess
2020-03-03 16:29 ` Sergio Durigan Junior
2020-03-03 16:49 ` Sergio Durigan Junior
2020-03-04 10:53 ` Joel Brobecker [this message]
[not found] ` <8736al5d8s.fsf@redhat.com>
2020-03-07 11:58 ` Joel Brobecker
2020-03-09 22:56 ` Sergio Durigan Junior
2020-03-10 22:37 ` Joel Brobecker
2020-03-10 22:57 ` Sergio Durigan Junior
2020-03-10 23:13 ` Andreas Schwab
2020-03-10 23:38 ` Sergio Durigan Junior
2020-03-11 16:34 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200304105330.GA4745@adacore.com \
--to=brobecker@adacore.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=philippe.waroquiers@skynet.be \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox