Re: [PATCHv2] gdb/fortran: Fix printing of logical true values for Flang

Tom Tromey
2020-03-03T16:32:06Z

>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:

Andrew> Thanks for looking into this. I think that the best solution right
Andrew> now will be to handle TYPE_CODE_BOOL in f_val_print rather than
Andrew> modifying generic_val_print_bool.

Agreed.

Andrew> The other possibility would be, I think, to add a new field to 'struct
Andrew> language_defn' and use this in generic_val_print_bool instead of
Andrew> comparing the value of current_lanuage directly, however, this isn't
Andrew> the common approach, so I'd prefer to handle this case just like other
Andrew> TYPE_CODE_* are handled for now.

It would be nice if we could get away from having separate printing code
for each language. I don't know how practical this is though.

Andrew> I know that in places within GDB we do compare the value of
Andrew> current_lanuage to the know language structures, but I'd like to move
Andrew> us away from doing this.

Also agreed.

Tom