Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [committed][gdb/testsuite] Fix mi-sym-info.exp with check-read1
Date: Tue, 03 Mar 2020 09:35:00 -0000	[thread overview]
Message-ID: <20200303093545.GA8219@delia> (raw)

Hi,

When running gdb.mi/mi-sym-info.exp with check-read1, we run into:
...
FAIL: gdb.mi/mi-sym-info.exp: List all functions
FAIL: gdb.mi/mi-sym-info.exp: List all variables
...

The problem is that while the $mi_gdb_prompt is active, gdb_test_multiple is
used without -prompt "$mi_gdb_prompt$", so it defaults to matching $gdb_prompt.

Fix this by adding the missing gdb_test_multiple arguments.

Reg-tested on x86_64-linux with make targets check and check-read1.

Committed to trunk.

Thanks,
- Tom

[gdb/testsuite] Fix mi-sym-info.exp with check-read1

gdb/testsuite/ChangeLog:

2020-03-03  Tom de Vries  <tdevries@suse.de>

	* gdb.mi/mi-sym-info.exp: Add missing -prompt "$mi_gdb_prompt$" to
	gdb_test_multiple calls.

---
 gdb/testsuite/gdb.mi/mi-sym-info.exp | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gdb/testsuite/gdb.mi/mi-sym-info.exp b/gdb/testsuite/gdb.mi/mi-sym-info.exp
index 9df683ad9d..c07f3e8097 100644
--- a/gdb/testsuite/gdb.mi/mi-sym-info.exp
+++ b/gdb/testsuite/gdb.mi/mi-sym-info.exp
@@ -68,7 +68,8 @@ mi_gdb_test "113-symbol-info-types" \
 # this command that we overflow expect's buffers, avoid this by
 # fetching the output piece by piece.
 set testname "List all functions"
-gdb_test_multiple "114-symbol-info-functions --include-nondebug" ${testname} {
+set cmd "114-symbol-info-functions --include-nondebug"
+gdb_test_multiple $cmd ${testname} -prompt "${mi_gdb_prompt}$" {
     -re "114\\^done,symbols=\{debug=\\\[${symtab_re}(?:,${symtab_re})*\\\],nondebug=\\\[" {
 	exp_continue
     }
@@ -83,7 +84,8 @@ gdb_test_multiple "114-symbol-info-functions --include-nondebug" ${testname} {
 }
 
 set testname "List all variables"
-gdb_test_multiple "115-symbol-info-variables --include-nondebug" ${testname} {
+set cmd "115-symbol-info-variables --include-nondebug"
+gdb_test_multiple $cmd ${testname} -prompt "${mi_gdb_prompt}$" {
     -re "115\\^done,symbols=\{debug=\\\[${symtab_re}(?:,${symtab_re})*\\\],nondebug=\\\[" {
 	verbose -log "Got the first part of the input"
 	exp_continue


                 reply	other threads:[~2020-03-03  9:35 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200303093545.GA8219@delia \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox