From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82135 invoked by alias); 28 Feb 2020 13:36:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 82127 invoked by uid 89); 28 Feb 2020 13:36:20 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=1.1 required=5.0 tests=BAYES_00,FREEMAIL_FROM,FSL_HELO_FAKE,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.1 spammy=H*i:sk:9c256b2, H*MI:sk:9c256b2, H*f:sk:9c256b2, HX-Languages-Length:1712 X-HELO: mail-wm1-f67.google.com Received: from mail-wm1-f67.google.com (HELO mail-wm1-f67.google.com) (209.85.128.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Feb 2020 13:36:19 +0000 Received: by mail-wm1-f67.google.com with SMTP id a5so3245240wmb.0 for ; Fri, 28 Feb 2020 05:36:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ynI3kwwHCwAt5u7gSHAH5vQNcSGZEGqPEJ52DiFltmE=; b=Bd5FgleDRz2kZTbdxDmqJDEo/6/WholRpOlGCLxxaIE226Q3gh2G5HD0/Q6HoMxbQ1 2Ptgh9Zwr6SZdJm+5ZIaq7AR7k4P8Pv1Q0XynYP2FqWfELhy8ldazHVA4iAc8KDyxOZB vZFlTflM7yApXQB0zqX4+G38Wpv4DYn8AwIjix0tx++1sqRLPe80P5E15AVFlBcyqrsR fkfMwYrnjSwJUJNRQlCu5Veem/v0d4X6hsao2PaTK83z7aNflxHm+7dcQk5ho3LnZbj8 5fJqsAV0JzJspNaLKT7NGPs9UqHzGZyzWeewKOTUAFS07vRWhRIyYULCJ1KgWpKqe9EW WQGA== Return-Path: Received: from gmail.com ([2a03:1b20:3:f011::6d]) by smtp.gmail.com with ESMTPSA id v2sm13513980wme.2.2020.02.28.05.36.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 28 Feb 2020 05:36:16 -0800 (PST) Date: Fri, 28 Feb 2020 13:36:00 -0000 From: Shahab Vahedi To: Luis Machado Cc: Christian Biesinger , Shahab Vahedi , "gdb-patches@sourceware.org" , Claudiu Zissulescu , Francois Bedard , Andrew Burgess Subject: Re: [Regression] [PATCH] Do not print empty-group regs when printing general ones Message-ID: <20200228133618.GA3269@gmail.com> References: <20200120155315.30333-1-shahab.vahedi@gmail.com> <75f76108-a233-6fce-66a2-86452371e1be@linaro.org> <9c256b27-4a00-8830-46e2-934922e39cc2@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9c256b27-4a00-8830-46e2-934922e39cc2@linaro.org> X-SW-Source: 2020-02/txt/msg01043.txt.bz2 On Fri, Feb 28, 2020 at 10:31:26AM -0300, Luis Machado wrote: > > > On 2/28/20 10:22 AM, Christian Biesinger wrote: > > On Fri, Feb 28, 2020 at 7:08 AM Luis Machado wrote: > > > > > > On 1/31/20 7:34 AM, Shahab Vahedi wrote: > > > > This patch was reviewed once (as OK): > > > > https://sourceware.org/ml/gdb-patches/2020-01/msg00613.html > > > > > > > > Could someone review/merge it? > > > > > > > > > > > > Cheers, > > > > Shahab > > > > > > > > > > FTR, this has broken general register printing for ARM/AArch64. Now > > > "info reg" shows nothing. > > > > > > Given there are already remote stubs, probes and gdbservers running out > > > there, this is an undesirable change to have. > > > > > > I had an IRC chat with Christian and he pointed me at some documentation > > > stating empty-group registers should not be printed, but i think this is > > > a case where the implementation has diverged from the documentation. > > > > > > https://sourceware.org/gdb/current/onlinedocs/gdb/Target-Description-Format.html#Target-Description-Format > > > > > > We could probably patch up any non-standard target description XML's > > > from now on, but the existing behavior may have to be preserved. > > > > Most targets under features/ do not specify group="general" in their > > XML files for anything (only S/390 does); it seems like that should > > maybe be fixed either way? > > I agree. The documentation [1] says: If no group is specified, GDB will not display the register in info registers [1] https://sourceware.org/gdb/onlinedocs/gdb/Target-Description-Format.html#Target-Description-Format