From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101010 invoked by alias); 26 Feb 2020 20:06:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 100941 invoked by uid 89); 26 Feb 2020 20:06:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-16.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=HX-Languages-Length:962 X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (205.139.110.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Feb 2020 20:06:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582747585; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xHjG5FjzrmgB7b+SfDPPas8FuZreGF0YrWBicvsUaMw=; b=dMQMn0+DjL0hM+grJgRdLOLZSjX6rL5XxYejVqsP8YAd96pR7Wwyat9kzU6yoMgR/4mtJe OZufUSFyLQbccZqRMmMliXxBU1uen891XfSHfkvpwQ/qMwrWPw14MI8YPlvnTSZAAtyuxZ +K+ah/4BKWf00dMNnAJxQI1es8BNe1I= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-66-hLKrVvI0NlSufuqPe1uTKA-1; Wed, 26 Feb 2020 15:06:23 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9850A800D50; Wed, 26 Feb 2020 20:06:22 +0000 (UTC) Received: from psique.yyz.redhat.com (unused-10-15-17-54.yyz.redhat.com [10.15.17.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id EE38B5DA76; Wed, 26 Feb 2020 20:06:21 +0000 (UTC) From: Sergio Durigan Junior To: GDB Patches Cc: Pedro Alves , Tom Tromey , Eli Zaretskii , Ruslan Kabatsayev , Sergio Durigan Junior Subject: [PATCH 6/6] Fix comment for 'gdb_dlopen' Date: Wed, 26 Feb 2020 20:06:00 -0000 Message-Id: <20200226200542.746617-7-sergiodj@redhat.com> In-Reply-To: <20200226200542.746617-1-sergiodj@redhat.com> References: <20190926042155.31481-1-sergiodj@redhat.com> <20200226200542.746617-1-sergiodj@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg00988.txt.bz2 The 'gdb_dlopen' function doesn't return NULL if the shlib load fails;n it actually throws an error. This patch updates the comment to reflect this. gdbsupport/ChangeLog: yyyy-mm-dd Sergio Durigan Junior * gdb-dlfcn.h (gdb_dlopen): Update comment. --- gdbsupport/gdb-dlfcn.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdbsupport/gdb-dlfcn.h b/gdbsupport/gdb-dlfcn.h index 258cfebbc3..9e72a53dc0 100644 --- a/gdbsupport/gdb-dlfcn.h +++ b/gdbsupport/gdb-dlfcn.h @@ -32,8 +32,8 @@ struct dlclose_deleter typedef std::unique_ptr gdb_dlhandle_up; =20 /* Load the dynamic library file named FILENAME, and return a handle - for that dynamic library. Return NULL if the loading fails for any - reason. */ + for that dynamic library. Throw an error if the loading fails for + any reason. */ =20 gdb_dlhandle_up gdb_dlopen (const char *filename); =20 --=20 2.24.1