From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94519 invoked by alias); 21 Feb 2020 03:57:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 94482 invoked by uid 89); 21 Feb 2020 03:57:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Feb 2020 03:57:23 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id C97B011698A; Thu, 20 Feb 2020 22:57:21 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id hvhNsLpMFljk; Thu, 20 Feb 2020 22:57:21 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 7113A116788; Thu, 20 Feb 2020 22:57:21 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 22E1983853; Fri, 21 Feb 2020 07:57:17 +0400 (+04) Date: Fri, 21 Feb 2020 03:57:00 -0000 From: Joel Brobecker To: Sergio Durigan Junior Cc: Tom Tromey , GDB Patches Subject: Re: [PATCH] Make '{putchar,fputc}_unfiltered' use 'fputs_unfiltered' Message-ID: <20200221035717.GA21588@adacore.com> References: <20200220041214.155369-1-sergiodj@redhat.com> <87v9o1ghdm.fsf@tromey.com> <87ftf5x96i.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ftf5x96i.fsf@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2020-02/txt/msg00844.txt.bz2 Hi Sergio and Tom, On Thu, Feb 20, 2020 at 04:04:05PM -0500, Sergio Durigan Junior wrote: > On Thursday, February 20 2020, Tom Tromey wrote: > > >>>>>> "Sergio" == Sergio Durigan Junior writes: > > > > Sergio> gdb/ChangeLog: > > Sergio> 2020-02-20 Sergio Durigan Junior > > Sergio> Tom Tromey > > Sergio> * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead > > Sergio> of 'fputc_unfiltered'. > > Sergio> (putchar_unfiltered): Call 'fputc_unfiltered'. > > Sergio> (fputc_unfiltered): Call 'fputs_unfiltered'. > > > > Looks good to me. Thanks for doing this. > > Thanks, pushed. > > 3f702acd7d562d3a33c59d6398ae74058438d2c7 I think the commit that Sergio incriminated is also in gdb-9-branch. Do you confirm? If yes, what about creating a GDB PR, and backporting this change to the gdb-9-branch (all changes after the .1 must have a PR)? The change looks relatively safe to me, but maybe it's not as simple as we might think, especially since this section of the code _is_ quite central... Thank you! -- Joel