Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>, Pedro Alves <palves@redhat.com>
Subject: [committed][gdb/testsuite] Fix c++/14186 kpass in cpexprs.exp
Date: Wed, 19 Feb 2020 12:46:00 -0000	[thread overview]
Message-ID: <20200219124557.GA23645@delia> (raw)

Hi,

With gdb.cp/cpexprs.exp, we see:
...
KPASS: gdb.cp/cpexprs.exp: p CV::m(int) const (PRMS c++/14186)
KPASS: gdb.cp/cpexprs.exp: p CV::m(int) volatile (PRMS c++/14186)
KPASS: gdb.cp/cpexprs.exp: p CV::m(int) const volatile (PRMS c++/14186)
...

The tests have been KPASSing since Sept 4 2017, due to commit 3693fdb3c8
'Make "p S::method() const::static_var" work too'.

Fix this by removing the corresponding kfail.

Committed to trunk.

[ Removing the kfail was proposed and approved by Tom and Pedro in PR14186
comment 4 and 5. ]

Thanks,
- Tom

[gdb/testsuite] Fix c++/14186 kpass in cpexprs.exp

gdb/testsuite/ChangeLog:

2020-02-19  Tom de Vries  <tdevries@suse.de>

	* gdb.cp/cpexprs.exp: Remove c++/14186 kfail.

---
 gdb/testsuite/gdb.cp/cpexprs.exp | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/gdb/testsuite/gdb.cp/cpexprs.exp b/gdb/testsuite/gdb.cp/cpexprs.exp
index 9ccb94cf40..e8b898fa11 100644
--- a/gdb/testsuite/gdb.cp/cpexprs.exp
+++ b/gdb/testsuite/gdb.cp/cpexprs.exp
@@ -731,9 +731,6 @@ foreach cv {{} { const} { volatile} { const volatile}} {
 	  pass $test
       }
   }
-  if {"$cv" != ""} {
-      setup_kfail c++/14186 *-*-*
-  }
   gdb_test "p CV::m(int)$cv" [string_to_regexp $correct]
 }
 


                 reply	other threads:[~2020-02-19 12:46 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200219124557.GA23645@delia \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox