Re: [PATCH][gdb/testsuite] Be quiet about untested dtrace-prob.exp

Tom de Vries
2020-02-18T13:36:54Z

On 18-02-2020 14:20, Luis Machado wrote:
> On 2/18/20 10:13 AM, Tom de Vries wrote:
>> On 18-02-2020 13:35, Luis Machado wrote:
>>> On 2/18/20 9:02 AM, Tom de Vries wrote:
>>>> Hi,
>>>>
>>>> When running gdb.base/dtrace-probe.exp, I get this on stdout/stderr:
>>>> ...
>>>> Running src/gdb/testsuite/gdb.base/dtrace-probe.exp ...
>>>> gdb compile failed, ld: error in \
>>>> Â Â Â  build/gdb/testsuite/outputs/gdb.base/dtrace-probe/dtrace-probe.o\
>>>> Â Â Â  (.eh_frame); no .eh_frame_hdr table will be created
>>>> ld: crt1.o: in function `_start':
>>>> start.S:110: undefined reference to `main'
>>>> ld:
>>>> build/gdb/testsuite/outputs/gdb.base/dtrace-probe/dtrace-probe-p.o:\
>>>> Â Â Â  (.SUNW_dof+0x88): undefined reference to `main'
>>>> ld:
>>>> build/gdb/testsuite/outputs/gdb.base/dtrace-probe/dtrace-probe-p.o:\
>>>> Â Â Â  (.SUNW_dof+0xb8): undefined reference to `main'
>>>> collect2: error: ld returned 1 exit status
>>>>
>>>> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â  === gdb Summary ===
>>>>
>>>> nr of untested testcasesÂ Â Â Â Â Â Â Â  1
>>>
>>> Odd. I'm running this natively on aarch64 and i don't see the same. I
>>> only get output in gdb.log.
>>>
>>
>> I've looked a bit at the semantics of output_clone (in
>> /usr/share/dejagnu/framework.exp), and the only way I could think of how
>> that would happen for you is if the output somehow starts with a keyword
>> like PASS/FAIL/WARNING/ERROR/etc. [ If you want to chase that difference
>> it could be useful to post a gdb.log/gdb.sum/stdout_stderr.log. ]
>
> I think the setup i have differs from yours. I don't have DTtrace, so
> the testsuite ends up using pdtrace.

Same here.

> That somehow makes things go a
> different way. The build ends up failing, but silently.
>
> as: unrecognized option '-64
> readelf: Error:
> 'binutils-gdb-master/gdb/testsuite/outputs/gdb.base/dtrace-probe/dtrace-probe-p.o':
> No such file
> error: could not extract the start of shdr from
> binutils-gdb-master/gdb/testsuite/outputs/gdb.base/dtrace-probe/dtrace-probe-p.o
>
> UNTESTED: gdb.base/dtrace-probe.exp: failed to compile

OK, that explains it. In both cases, dtrace_build_usdt_test_program
fails, in my case in a gdb_compile call, in your case in one of the
$dtrace calls (my guess is the second one).

Thanks,
- Tom