Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [PATCH][gdb/testsuite] Ignore pass/fail/unsupported in gdb-caching-proc.exp
Date: Thu, 13 Feb 2020 10:58:00 -0000	[thread overview]
Message-ID: <20200213105754.GA22520@delia> (raw)

Hi,

After de-installing gnatmake, I get:
...
Running src/gdb/testsuite/gdb.base/gdb-caching-proc.exp ...
FAIL: gdb-caching-proc.exp: failed to compile gnat-debug-info test binary
  ...
FAIL: gdb-caching-proc.exp: failed to compile gnat-debug-info test binary
...

In gdb.sum, we see these FAILs (each paired with an UNSUPPORTED as well)
followed by:
...
PASS: gdb-caching-proc.exp: gnat_runtime_has_debug_info consistency
...

Fix this by ignoring PASS/FAIL/UNSUPPORTED during testing, such that we have
just the consistency PASS/FAIL.

Tested on x86_64-linux, with gnatmake installed and de-installed.

OK for trunk?

Thanks,
- Tom

[gdb/testsuite] Ignore pass/fail/unsupported in gdb-caching-proc.exp

gdb/testsuite/ChangeLog:

2020-02-13  Tom de Vries  <tdevries@suse.de>

	* gdb.base/gdb-caching-proc.exp (ignore_pass, ignore_fail)
	(ignore_unsupported): New proc.
	(test_proc): Temporarily rename pass/fail/ignore to
	ignore_{pass,fail,ignore} in order to ignore PASS/FAIL/IGNORE messages
	from the tested procs.

---
 gdb/testsuite/gdb.base/gdb-caching-proc.exp | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gdb/testsuite/gdb.base/gdb-caching-proc.exp b/gdb/testsuite/gdb.base/gdb-caching-proc.exp
index b2d71a5e7d..536d7e89c1 100644
--- a/gdb/testsuite/gdb.base/gdb-caching-proc.exp
+++ b/gdb/testsuite/gdb.base/gdb-caching-proc.exp
@@ -22,12 +22,29 @@
 # number of reruns is constant-bounded, and the increase in runtime is bound to
 # this test-case, and could be disabled on slow targets.
 
+proc ignore_pass { args } {
+
+}
+proc ignore_fail { args } {
+
+}
+proc ignore_unsupported { args } {
+
+}
+
 # Test gdb_caching_proc NAME
 proc test_proc { name } {
     set real_name gdb_real__$name
 
     set resultlist [list]
 
+    rename pass save_pass
+    rename fail save_fail
+    rename unsupported save_unsupported
+    rename ignore_pass pass
+    rename ignore_fail fail
+    rename ignore_unsupported unsupported
+
     set first [$real_name]
     lappend resultlist $first
 
@@ -44,6 +61,13 @@ proc test_proc { name } {
 	}
     }
 
+    rename pass ignore_pass
+    rename fail ignore_fail
+    rename unsupported ignore_unsupported
+    rename save_pass pass
+    rename save_fail fail
+    rename save_unsupported unsupported
+
     if { $racy  == 0 } {
 	pass "$name consistency"
     } else {


             reply	other threads:[~2020-02-13 10:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-13 10:58 Tom de Vries [this message]
2020-02-13 14:32 ` Tom Tromey
2020-02-13 15:02   ` Tom de Vries
2020-02-17 20:52     ` Simon Marchi
2020-02-17 23:23       ` Tom de Vries
2020-02-17 23:58         ` Simon Marchi
     [not found]           ` <e5d1fcce-1d24-29cf-e7e2-6ea177092ab2@suse.de>
2020-02-18 10:59             ` [RFC][gdb/testsuite] Ignore pass in gdb_caching_proc Tom de Vries
2020-02-18 15:29               ` Tom Tromey
2020-02-19  6:07                 ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200213105754.GA22520@delia \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox